From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xooyb-0008SN-Mc for barebox@lists.infradead.org; Thu, 13 Nov 2014 07:37:58 +0000 Date: Thu, 13 Nov 2014 08:37:32 +0100 From: Sascha Hauer Message-ID: <20141113073732.GN30369@pengutronix.de> References: <1415778114-41864-1-git-send-email-j.weitzel@phytec.de> <1415778114-41864-2-git-send-email-j.weitzel@phytec.de> <20141112082217.GJ30369@pengutronix.de> <54632760.9050205@phytec.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54632760.9050205@phytec.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/2] ARM: omap: Add bootsource serial to xload To: Jan Weitzel Cc: barebox@lists.infradead.org On Wed, Nov 12, 2014 at 10:24:48AM +0100, Jan Weitzel wrote: > Am 12.11.2014 um 09:22 schrieb Sascha Hauer: > >Hi Jan, > > > >On Wed, Nov 12, 2014 at 08:41:54AM +0100, Jan Weitzel wrote: > >>If booted from serial via xmodem, also get barebox.bin per xmodem > >>For first stage you need the .pblx file instead of MLO. > >> > >>Signed-off-by: Jan Weitzel > >>--- > >> arch/arm/mach-omap/Kconfig | 7 +++++++ > >> arch/arm/mach-omap/xload.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > >> 2 files changed, 53 insertions(+) > >> > >>diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig > >>index f9b5ec3..953dd8f 100644 > >>--- a/arch/arm/mach-omap/Kconfig > >>+++ b/arch/arm/mach-omap/Kconfig > >>@@ -118,6 +118,13 @@ config OMAP4_USBBOOT > >> You need the utility program omap4_usbboot to boot from USB. > >> Please read omap4_usb_booting.txt for more information. > >>+config OMAP_SERIALBOOT > >>+ bool > >>+ default y > >No default y please. Better keep it disabled by default because the > >OMAP4 xload configs are quiet tight I think. > > Is adding it to am335x_mlo_defconfig ok? Because of the size I added the > ARCH_AM33XX dependency. I overlooked this dependency. So the dependency is only because of the binary size and it's otherwise usable on Omap aswell? In this case I suggest to drop the dependency. And yes, ok to add it to the am335x_mlo_defconfig. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox