From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XstFB-0006Sy-7H for barebox@lists.infradead.org; Mon, 24 Nov 2014 12:59:54 +0000 Date: Mon, 24 Nov 2014 13:59:31 +0100 From: Sascha Hauer Message-ID: <20141124125931.GH30369@pengutronix.de> References: <1416827220-3103-1-git-send-email-l.stach@pengutronix.de> <1416827220-3103-18-git-send-email-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1416827220-3103-18-git-send-email-l.stach@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 17/20] blspec: depend on, not select flexible bootargs To: Lucas Stach Cc: barebox@lists.infradead.org On Mon, Nov 24, 2014 at 12:06:57PM +0100, Lucas Stach wrote: > Blspec is a consumer of the flexible bootargs mechanism, so it should > depend on it rather than select it. > > Fixes: > warning: (BLSPEC && DEFAULT_ENVIRONMENT_GENERIC_NEW) selects FLEXIBLE_BOOTARGS > which has unmet direct dependencies (COMMAND_SUPPORT && CMD_GLOBAL) > > Signed-off-by: Lucas Stach > --- > common/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/Kconfig b/common/Kconfig > index a2cce391f461..6583aabc44d9 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -478,8 +478,8 @@ config TIMESTAMP > > config BLSPEC > depends on BLOCK > + depends on FLEXIBLE_BOOTARGS > select OFTREE > - select FLEXIBLE_BOOTARGS This effectively disables BLSPEC support in these configs: arch/arm/configs/tegra_v7_defconfig:17:CONFIG_BLSPEC=y arch/arm/configs/rpi_defconfig:14:CONFIG_BLSPEC=y arch/arm/configs/imx_defconfig:22:CONFIG_BLSPEC=y arch/arm/configs/imx_v7_defconfig:40:CONFIG_BLSPEC=y arch/arm/configs/mvebu_defconfig:18:CONFIG_BLSPEC=y arch/arm/configs/am335x_defconfig:25:CONFIG_BLSPEC=y arch/arm/configs/tqma53_defconfig:19:CONFIG_BLSPEC=y You have to add a CONFIG_FLEXIBLE_BOOTARGS=y in these files. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox