From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] usb: musb: only build musb_barebox if host is enabled
Date: Thu, 27 Nov 2014 17:13:09 +0100 [thread overview]
Message-ID: <20141127161309.GW30369@pengutronix.de> (raw)
In-Reply-To: <1417103660-32348-1-git-send-email-l.stach@pengutronix.de>
On Thu, Nov 27, 2014 at 04:54:17PM +0100, Lucas Stach wrote:
> musb_barebox.c contains code that is only ever used if CONFIG_MUSB_HOST
> is set. Building it uncoditionally breaks the build depending on the link
> order.
>
> Fixes:
> drivers/usb/musb/musb_barebox.c:64: undefined reference to `musb_urb_enqueue'
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied all, thanks
Sascha
> ---
> drivers/usb/musb/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/Makefile b/drivers/usb/musb/Makefile
> index 364a43fecb62..9f9c21030047 100644
> --- a/drivers/usb/musb/Makefile
> +++ b/drivers/usb/musb/Makefile
> @@ -2,9 +2,9 @@
> # for USB OTG silicon based on Mentor Graphics INVENTRA designs
> #
>
> -obj-y += musb_core.o musb_barebox.o
> +obj-y += musb_core.o
>
> -obj-$(CONFIG_USB_MUSB_HOST) += musb_host.o
> +obj-$(CONFIG_USB_MUSB_HOST) += musb_host.o musb_barebox.o
> obj-$(CONFIG_USB_MUSB_GADGET) += musb_gadget.o musb_gadget_ep0.o
>
> obj-$(CONFIG_USB_MUSB_DSPS) += musb_dsps.o
> --
> 2.1.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-11-27 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 15:54 Lucas Stach
2014-11-27 15:54 ` [PATCH 2/4] rtc: select GREGORIAN_CALENDER Lucas Stach
2014-11-27 15:54 ` [PATCH 3/4] arm: imx: iim/ocotp: fix link error when !CONFIG_NET Lucas Stach
2014-11-27 15:54 ` [PATCH 4/4] net: rtl8139: depend on MIPS Lucas Stach
2014-11-27 16:13 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127161309.GW30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox