From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y86Wo-0005fF-Am for barebox@lists.infradead.org; Mon, 05 Jan 2015 12:13:00 +0000 Date: Mon, 5 Jan 2015 13:12:35 +0100 From: Sascha Hauer Message-ID: <20150105121235.GD4544@pengutronix.de> References: <1420142663-6243-1-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1420142663-6243-1-git-send-email-robert.jarzmik@free.fr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] commands: loady: fix bug with netconsole To: Robert Jarzmik Cc: barebox@lists.infradead.org On Thu, Jan 01, 2015 at 09:04:21PM +0100, Robert Jarzmik wrote: > Netconsole doesn't have a baudrate. Loady supposes a console has one, > and tries to compute the console's baudrate variable value, regardless > of its existence. > > This triggers a NULL pointer dereference on netconsole. If attempting > loady on a netconsole is a bit useless, barebox should not panic. Fix > this by checking the variable exists before reading its value. > > Signed-off-by: Robert Jarzmik Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox