From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-x233.google.com ([2a00:1450:4010:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y8BHc-0008Dz-1C for barebox@lists.infradead.org; Mon, 05 Jan 2015 17:17:36 +0000 Received: by mail-la0-f51.google.com with SMTP id ms9so18411428lab.24 for ; Mon, 05 Jan 2015 09:17:09 -0800 (PST) Date: Mon, 5 Jan 2015 20:19:33 +0300 From: Antony Pavlov Message-Id: <20150105201933.75e448ef02ad9e9e31ac6663@gmail.com> In-Reply-To: <1420405745-4408-1-git-send-email-dev@lynxeye.de> References: <1420405745-4408-1-git-send-email-dev@lynxeye.de> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] net: rtl8169: remove unnecessary cache maintenance To: Lucas Stach Cc: barebox@lists.infradead.org On Sun, 4 Jan 2015 22:09:05 +0100 Lucas Stach wrote: I suppose that this patch can make problems on MIPS with explicid cache han= dling. > The buffer descriptors are allocated from coherent memory, so there > is no cache maintenance needed. Only tell the compiler that the descripto= rs > can be modified by the hardware. > = > Signed-off-by: Lucas Stach > --- > drivers/net/rtl8169.c | 24 +++++------------------- > 1 file changed, 5 insertions(+), 19 deletions(-) > = > diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c > index 5702900..19f5763 100644 > --- a/drivers/net/rtl8169.c > +++ b/drivers/net/rtl8169.c > @@ -50,11 +50,11 @@ struct rtl8169_priv { > struct pci_dev *pci_dev; > int chipset; > = > - struct bufdesc *tx_desc; > + volatile struct bufdesc *tx_desc; > void *tx_buf; > unsigned int cur_tx; > = > - struct bufdesc *rx_desc; > + volatile struct bufdesc *rx_desc; > void *rx_buf; > unsigned int cur_rx; > = > @@ -250,10 +250,6 @@ static void rtl8169_init_ring(struct rtl8169_priv *p= riv) > priv->rx_desc[i].buf_addr =3D > virt_to_phys(priv->rx_buf + i * PKT_BUF_SIZE); > } > - > - dma_flush_range((unsigned long)priv->rx_desc, > - (unsigned long)priv->rx_desc + > - NUM_RX_DESC * sizeof(struct bufdesc)); > } > = > static void rtl8169_hw_start(struct rtl8169_priv *priv) > @@ -386,14 +382,10 @@ static int rtl8169_eth_send(struct eth_device *edev= , void *packet, > ((packet_length > ETH_ZLEN) ? packet_length : ETH_ZLEN); > } > = > - dma_flush_range((unsigned long)&priv->tx_desc[entry], > - (unsigned long)&priv->tx_desc[entry + 1]); > - > RTL_W8(priv, TxPoll, 0x40); > - do { > - dma_inv_range((unsigned long)&priv->tx_desc[entry], > - (unsigned long)&priv->tx_desc[entry + 1]); > - } while (priv->tx_desc[entry].status & BD_STAT_OWN); > + > + while (priv->tx_desc[entry].status & BD_STAT_OWN) > + ; > = > priv->cur_tx++; > = > @@ -408,9 +400,6 @@ static int rtl8169_eth_rx(struct eth_device *edev) > = > entry =3D priv->cur_rx % NUM_RX_DESC; > = > - dma_inv_range((unsigned long)&priv->rx_desc[entry], > - (unsigned long)&priv->rx_desc[entry + 1]); > - > if ((priv->rx_desc[entry].status & BD_STAT_OWN) =3D=3D 0) { > if (!(priv->rx_desc[entry].status & BD_STAT_RX_RES)) { > pkt_size =3D (priv->rx_desc[entry].status & 0x1fff) - 4; > @@ -441,9 +430,6 @@ static int rtl8169_eth_rx(struct eth_device *edev) > priv->rx_desc[entry].buf_addr =3D > virt_to_phys(priv->rx_buf + > entry * PKT_BUF_SIZE); > - > - dma_flush_range((unsigned long)&priv->rx_desc[entry], > - (unsigned long)&priv->rx_desc[entry + 1]); > } else { > dev_err(&edev->dev, "rx error\n"); > } > -- = > 2.1.0 > = > = > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox -- = --=A0 Best regards, =A0 Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox