mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] resource: dev_request_mem_region: fix return value for MIPS
Date: Fri, 9 Jan 2015 17:10:24 +0100	[thread overview]
Message-ID: <20150109161024.GK23940@pengutronix.de> (raw)
In-Reply-To: <1420796497-28360-1-git-send-email-antonynpavlov@gmail.com>

On Fri, Jan 09, 2015 at 12:41:37PM +0300, Antony Pavlov wrote:
> The commit
> 
>     commit 0d7a21334536cb36b3c9b64d868acc55aec41332
>     Author: Antony Pavlov <antonynpavlov at gmail.com>
>     Date:   Wed Sep 10 11:42:19 2014 +0400
> 
>         MIPS: dts: use physical addresses (as Linux does)
> 
>         With IOMEM() adapted for MIPS we can use physical addresses
>         in device tree reg property.
> 
> has switched MIPS dts files to physical addresses usage.
> 
> The patch was tested on qemu, but qemu malta board is tolerant
> of using physical addresses for accesing to device
> (Ingenic JZ4755 and JZ4780 processors are tolerant too!).
> But other CPUs (e.g. Loongson LS1B) can throw an exception
> in this situation.
> 
> Additional physical address to virtual address translation
> on MIPS is needed.
> 
> We already have this in include/common.h
> 
>     #if defined(CONFIG_MIPS)
>     #include <asm/addrspace.h>
> 
>     #define IOMEM(addr) ((void __force __iomem *)CKSEG1ADDR(addr))
>     #else
>     #define IOMEM(addr) ((void __force __iomem *)(addr))
>     #endif
> 
> So use IOMEM() to fix dev_request_mem_region() return value.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-01-09 16:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09  9:41 Antony Pavlov
2015-01-09 16:10 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150109161024.GK23940@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox