From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YCxzY-0005df-Rr for barebox@lists.infradead.org; Sun, 18 Jan 2015 22:06:46 +0000 Received: by mail-la0-f47.google.com with SMTP id hz20so25927723lab.6 for ; Sun, 18 Jan 2015 14:06:21 -0800 (PST) Date: Mon, 19 Jan 2015 02:08:58 +0400 From: Antony Pavlov Message-Id: <20150119020858.8ba6db8d84cb7e795078ba99@gmail.com> In-Reply-To: <1421130790-1164-2-git-send-email-plagnioj@jcrosoft.com> References: <20150113063128.GC30554@ns203013.ovh.net> <1421130790-1164-1-git-send-email-plagnioj@jcrosoft.com> <1421130790-1164-2-git-send-email-plagnioj@jcrosoft.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/6] raspberry-pi: add leds support To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Tue, 13 Jan 2015 07:33:06 +0100 Jean-Christophe PLAGNIOL-VILLARD wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > arch/arm/boards/raspberry-pi/rpi.c | 55 ++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 55 insertions(+) > = > diff --git a/arch/arm/boards/raspberry-pi/rpi.c b/arch/arm/boards/raspber= ry-pi/rpi.c > index ae1e92a..81b485e 100644 > --- a/arch/arm/boards/raspberry-pi/rpi.c > +++ b/arch/arm/boards/raspberry-pi/rpi.c ... > @@ -160,6 +205,15 @@ unknown_rev: > barebox_set_model("RaspberryPi (BCM2835/ARM1176JZF-S)"); > } > = > +static void rpi_model_init(void) > +{ > + if (!models[rpi_board_rev].init) > + return; Houston, we have a problem here. Please see current arch/arm/boards/raspberry-pi/rpi.c: /* See comments in mbox.h for data source */ static const struct { const char *name; bool has_onboard_eth; void (*init)(void); } models[] =3D { RPI_MODEL(0, "Unknown model", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_I2C0_2, "Model B (no P5)", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_I2C0_3, "Model B (no P5)", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_I2C1_4, "Model B", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_I2C1_5, "Model B", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_I2C1_6, "Model B", NULL), RPI_MODEL(BCM2835_BOARD_REV_A_7, "Model A", NULL), RPI_MODEL(BCM2835_BOARD_REV_A_8, "Model A", NULL), RPI_MODEL(BCM2835_BOARD_REV_A_9, "Model A", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_REV2_d, "Model B rev2", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_REV2_e, "Model B rev2", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_REV2_f, "Model B rev2", NULL), RPI_MODEL(BCM2835_BOARD_REV_B_PLUS, "Model B+", NULL), RPI_MODEL(BCM2835_BOARD_REV_CM, "Compute Module", NULL), RPI_MODEL(BCM2835_BOARD_REV_A_PLUS, "Model A+", NULL), }; All inits are NULLs! Have we any chance to run rpi_add_led()? > + > + models[rpi_board_rev].init(); > + rpi_add_led(); > +} > + > static int rpi_mem_init(void) > { > u32 size =3D 0; > @@ -220,6 +274,7 @@ static int rpi_env_init(void) > = > static int rpi_devices_init(void) > { > + rpi_model_init(); > bcm2835_register_mci(); > bcm2835_register_fb(); > armlinux_set_architecture(MACH_TYPE_BCM2708); > -- = > 2.1.3 > = > = > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox -- = --=A0 Best regards, =A0 Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox