mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fixup! raspberry-pi: add board model detection
@ 2015-01-18 22:15 Antony Pavlov
  2015-01-19  7:56 ` Sascha Hauer
  2015-01-19 12:16 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 3+ messages in thread
From: Antony Pavlov @ 2015-01-18 22:15 UTC (permalink / raw)
  To: barebox

---

The 'has_onboard_eth' field is unused.

---
 arch/arm/boards/raspberry-pi/rpi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boards/raspberry-pi/rpi.c b/arch/arm/boards/raspberry-pi/rpi.c
index 81b485e..108bd28 100644
--- a/arch/arm/boards/raspberry-pi/rpi.c
+++ b/arch/arm/boards/raspberry-pi/rpi.c
@@ -140,7 +140,6 @@ static void rpi_b_init(void)
 /* See comments in mbox.h for data source */
 static const struct {
 	const char *name;
-	bool has_onboard_eth;
 	void (*init)(void);
 } models[] = {
 	RPI_MODEL(0, "Unknown model", NULL),
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fixup! raspberry-pi: add board model detection
  2015-01-18 22:15 [PATCH] fixup! raspberry-pi: add board model detection Antony Pavlov
@ 2015-01-19  7:56 ` Sascha Hauer
  2015-01-19 12:16 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2015-01-19  7:56 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: barebox

On Mon, Jan 19, 2015 at 02:15:49AM +0400, Antony Pavlov wrote:
> ---
> 
> The 'has_onboard_eth' field is unused.
> 
> ---
>  arch/arm/boards/raspberry-pi/rpi.c | 1 -
>  1 file changed, 1 deletion(-)

Applied for now, but Jean Christophe, please fix the other issues
mentioned.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fixup! raspberry-pi: add board model detection
  2015-01-18 22:15 [PATCH] fixup! raspberry-pi: add board model detection Antony Pavlov
  2015-01-19  7:56 ` Sascha Hauer
@ 2015-01-19 12:16 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 3+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2015-01-19 12:16 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: barebox

On 02:15 Mon 19 Jan     , Antony Pavlov wrote:
> ---
> 
> The 'has_onboard_eth' field is unused.

nack it I need for the next patch dont remove it

Best REgards,
J.
> 
> ---
>  arch/arm/boards/raspberry-pi/rpi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boards/raspberry-pi/rpi.c b/arch/arm/boards/raspberry-pi/rpi.c
> index 81b485e..108bd28 100644
> --- a/arch/arm/boards/raspberry-pi/rpi.c
> +++ b/arch/arm/boards/raspberry-pi/rpi.c
> @@ -140,7 +140,6 @@ static void rpi_b_init(void)
>  /* See comments in mbox.h for data source */
>  static const struct {
>  	const char *name;
> -	bool has_onboard_eth;
>  	void (*init)(void);
>  } models[] = {
>  	RPI_MODEL(0, "Unknown model", NULL),
> -- 
> 2.1.4
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-19 12:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-18 22:15 [PATCH] fixup! raspberry-pi: add board model detection Antony Pavlov
2015-01-19  7:56 ` Sascha Hauer
2015-01-19 12:16 ` Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox