[PATCH] commands/splash: fix '-y' option handling

[PATCH] commands/splash: fix '-y' option handling

[Antony Pavlov]

The '-y' and '-o' options are independent,
so just add missing 'break'.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 commands/splash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/commands/splash.c b/commands/splash.c
index 9bd84fb..077c0e4 100644
--- a/commands/splash.c
+++ b/commands/splash.c
@@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
 			break;
 		case 'y':
 			s.y = simple_strtoul(optarg, NULL, 0);
+			break;
 		case 'o':
 			offscreen = 1;
 		}
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] commands/splash: fix '-y' option handling

[Sascha Hauer]

On Sun, Jan 25, 2015 at 04:22:13PM +0300, Antony Pavlov wrote:
> The '-y' and '-o' options are independent,
> so just add missing 'break'.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks.

> ---
>  commands/splash.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/commands/splash.c b/commands/splash.c
> index 9bd84fb..077c0e4 100644
> --- a/commands/splash.c
> +++ b/commands/splash.c
> @@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
>  			break;
>  		case 'y':
>  			s.y = simple_strtoul(optarg, NULL, 0);
> +			break;
>  		case 'o':
>  			offscreen = 1;

It is missing here aswell. It's the last case, so this is not currently
a bug, but it could easily turn into a bug once the next option is
added.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] commands/splash: fix '-y' option handling

[Jean-Christophe PLAGNIOL-VILLARD]

> On Jan 25, 2015, at 9:22 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> 
> The '-y' and '-o' options are independent,
> so just add missing 'break'.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> commands/splash.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/commands/splash.c b/commands/splash.c
> index 9bd84fb..077c0e4 100644
> --- a/commands/splash.c
> +++ b/commands/splash.c
> @@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
> 			break;
> 		case 'y':
> 			s.y = simple_strtoul(optarg, NULL, 0);
> +			break;
> 		case 'o':
> 			offscreen = 1;
> 		}
> -- 
> 2.1.4

I already send a patch weeks ago to fix

Best Regards,
J.
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] commands/splash: fix '-y' option handling

[Sascha Hauer]

On Mon, Jan 26, 2015 at 04:51:14PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> > On Jan 25, 2015, at 9:22 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> > 
> > The '-y' and '-o' options are independent,
> > so just add missing 'break'.
> > 
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > commands/splash.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/commands/splash.c b/commands/splash.c
> > index 9bd84fb..077c0e4 100644
> > --- a/commands/splash.c
> > +++ b/commands/splash.c
> > @@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
> > 			break;
> > 		case 'y':
> > 			s.y = simple_strtoul(optarg, NULL, 0);
> > +			break;
> > 		case 'o':
> > 			offscreen = 1;
> > 		}
> > -- 
> > 2.1.4
> 
> I already send a patch weeks ago to fix

I can only find this patch from you about splash in the last few months:

[PATCH 2/2] command/splash: fix return value

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox