From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YG1DZ-00036M-Ew for barebox@lists.infradead.org; Tue, 27 Jan 2015 08:09:50 +0000 Date: Tue, 27 Jan 2015 09:09:27 +0100 From: Sascha Hauer Message-ID: <20150127080927.GT12209@pengutronix.de> References: <1422013301-16827-1-git-send-email-d.lavnikevich@sam-solutions.com> <1422013735-19774-1-git-send-email-d.lavnikevich@sam-solutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1422013735-19774-1-git-send-email-d.lavnikevich@sam-solutions.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/2] dts:imx6:pfla02: Align nand partitions by 512k To: Dmitry Lavnikevich Cc: barebox@lists.infradead.org + Teresa, Jan and Christian On Fri, Jan 23, 2015 at 02:48:55PM +0300, Dmitry Lavnikevich wrote: > NAND chip used on phyFLEX-i.MX6 with 4GB NAND (MT29F32G08AFACAWP) has > 512k eraseblock size. > > Align NAND partitions by 512k to fix erase fails. > > Signed-off-by: Dmitry Lavnikevich > --- > arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi > index 32ce088fee48..52b279057a33 100644 > --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi > +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi > @@ -95,22 +95,22 @@ > > partition@1 { > label = "barebox-environment"; > - reg = <0x400000 0x20000>; > + reg = <0x400000 0x80000>; > }; > > partition@2 { > label = "oftree"; > - reg = <0x420000 0x20000>; > + reg = <0x480000 0x80000>; > }; The partition size for barebox-environment and the devicetree used to be one eraseblock only. Now it's again only one eraseblock at least for the 4k Page size variants. If one of those blocks is bad the board becomes unusable. I think the partitions should be at least two eraseblocks. That of course would make them quite big. Any opinions about this? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox