Re: [PATCH 0/3] mtd: nand: ONFI probing for x16 devices on i.MX25 (and others)

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Feb 05, 2015 at 10:21:29PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On an i.MX25 based machine barebox issued a warning during startup:
> 
> 	nand: Trying ONFI probe in 16 bits mode, aborting !
> 
> without much side effects as the NAND chip was detected correctly nevertheless.
> 
> On the quest to fix this warning I noticed that there isn't much justification
> to not probe via ONFI even in x16 mode in the presence of the read_byte
> callback that is correctly used in the ONFI detection code. But removing this
> early exit in the generic probe routines brought to light that the imx nand
> driver didn't implement this read_byte callback correctly.
> 
> This series first fixes the imx nand driver to implement the read_byte callback
> correctly and then "fixes" the ONFI code to try detection even in x16 mode.
> This made the above mentioned warning go away and print
> 
> 	nand: ONFI flash detected
> 
> instead \o/. The generic code change was mostly cherry-picked from Linux, so I
> kept the original author annotation here.
> 
> As an added bonus there is a little optimisation at the end of the series.
> 
> Best regards
> Uwe
> 
> Brian Norris (1):
>   mtd: nand: cleanup ONFI printed errors, warnings
> 
> Uwe Kleine-König (2):
>   mtd: nand-imx: fix byte reading in x16 mode
>   mtd: nand-imx: don't copy more bytes than read from hardware

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox