* [PATCH] pbl: remove start_barebox() stub
@ 2015-02-12 2:04 Masahiro Yamada
2015-02-12 9:50 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2015-02-12 2:04 UTC (permalink / raw)
To: barebox
PBL never calls start_barebox(). If it does, it is a bug.
Without this stub function, we can detect such a bug at link time.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
pbl/misc.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/pbl/misc.c b/pbl/misc.c
index 9065bf0..7e76120 100644
--- a/pbl/misc.c
+++ b/pbl/misc.c
@@ -13,9 +13,3 @@ void __noreturn panic(const char *fmt, ...)
{
while(1);
}
-
-void __noreturn start_barebox(void)
-{
- /* Should never be here in the pbl */
- hang();
-}
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pbl: remove start_barebox() stub
2015-02-12 2:04 [PATCH] pbl: remove start_barebox() stub Masahiro Yamada
@ 2015-02-12 9:50 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-02-12 9:50 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: barebox
On Thu, Feb 12, 2015 at 11:04:50AM +0900, Masahiro Yamada wrote:
> PBL never calls start_barebox(). If it does, it is a bug.
> Without this stub function, we can detect such a bug at link time.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-12 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-12 2:04 [PATCH] pbl: remove start_barebox() stub Masahiro Yamada
2015-02-12 9:50 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox