mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andrey Panov <rockford@yandex.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: Rockchip: Add DEBUG_LL based on mach-socfpga
Date: Thu, 12 Feb 2015 20:34:57 +0100	[thread overview]
Message-ID: <20150212193457.GI10842@pengutronix.de> (raw)
In-Reply-To: <1423768031-5014-1-git-send-email-rockford@yandex.ru>

Hello,

On Thu, Feb 12, 2015 at 10:07:11PM +0300, Andrey Panov wrote:
> --- /dev/null
> +++ b/arch/arm/mach-rockchip/include/mach/debug_ll.h
> @@ -0,0 +1,60 @@
> +#ifndef __MACH_DEBUG_LL_H__
> +#define __MACH_DEBUG_LL_H__
> +
> +#include <io.h>
> +
> +#if CONFIG_DEBUG_ROCKCHIP_UART_PORT == 0
> +#define UART_BASE	0x10124000
> +#endif
> +#if CONFIG_DEBUG_ROCKCHIP_UART_PORT == 1
> +#define UART_BASE	0x10126000
> +#endif
> +#if CONFIG_DEBUG_ROCKCHIP_UART_PORT == 2
> +#define UART_BASE	0x20064000
> +#endif
> +#if CONFIG_DEBUG_ROCKCHIP_UART_PORT == 3
> +#define UART_BASE	0x20068000
> +#endif
Better make use of DEBUG_UART_PHYS and DEBUG_UART_BASE.
And there is already DEBUG_RK29_UART[123] and DEBUG_RK3X_UART[0123] and
DEBUG_RK32_UART2. Doesn't one of those fit your needs?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-02-12 19:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 19:07 Andrey Panov
2015-02-12 19:34 ` Uwe Kleine-König [this message]
2015-02-12 19:45   ` Панов Андрей
2015-02-12 19:51     ` Uwe Kleine-König
2015-02-12 19:55       ` Панов Андрей
2015-02-12 19:57       ` Uwe Kleine-König
2015-02-12 20:00         ` Панов Андрей
2015-02-12 19:59       ` Lucas Stach
2015-02-13  6:22 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150212193457.GI10842@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rockford@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox