From: Sascha Hauer <s.hauer@pengutronix.de>
To: h.feurstein@gmail.com
Cc: Hubert Feurstein <hubert.feurstein@deto.at>, barebox@lists.infradead.org
Subject: Re: [PATCH] led: gpio: add support for default-state dt-property
Date: Tue, 17 Feb 2015 08:59:06 +0100 [thread overview]
Message-ID: <20150217075906.GP12209@pengutronix.de> (raw)
In-Reply-To: <1424091808-23455-1-git-send-email-h.feurstein@gmail.com>
On Mon, Feb 16, 2015 at 02:03:28PM +0100, h.feurstein@gmail.com wrote:
> From: Hubert Feurstein <hubert.feurstein@deto.at>
>
> This patch adds support for the default-state device tree property.
>
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
> drivers/led/led-gpio.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
> index a1a6617..69ad7e7 100644
> --- a/drivers/led/led-gpio.c
> +++ b/drivers/led/led-gpio.c
> @@ -204,6 +204,7 @@ static int led_gpio_of_probe(struct device_d *dev)
>
> for_each_child_of_node(dev->device_node, child) {
> struct gpio_led *gled;
> + const char *default_state;
> enum of_gpio_flags flags;
> int gpio;
> const char *label;
> @@ -225,6 +226,18 @@ static int led_gpio_of_probe(struct device_d *dev)
>
> led_gpio_register(gled);
> led_of_parse_trigger(&gled->led, child);
> +
> + if (!of_property_read_string(child, "default-state", &default_state)) {
> + int state = -1;
> +
> + if (!strcmp(default_state, "on"))
> + state = 1;
> + else if (!strcmp(default_state, "off"))
> + state = 0;
> +
> + if (state >= 0)
> + led_gpio_set(&gled->led, state ^ gled->active_low);
led_gpio_set already evaluates active_low, so doing it here again is
wrong.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-02-17 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 13:03 h.feurstein
2015-02-17 7:59 ` Sascha Hauer [this message]
2015-03-04 9:52 ` [PATCH v2] " Hubert Feurstein
2015-03-04 10:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217075906.GP12209@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=h.feurstein@gmail.com \
--cc=hubert.feurstein@deto.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox