mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: socfpga: add Altera SoCFPGA Development Kit support
Date: Mon, 23 Feb 2015 08:34:16 +0100	[thread overview]
Message-ID: <20150223073416.GK12209@pengutronix.de> (raw)
In-Reply-To: <7361axqaz3.fsf@dude.hi.pengutronix.de>

On Fri, Feb 20, 2015 at 08:49:04AM +0100, Steffen Trumtrar wrote:
> 
> Hi!
> 
> Sascha Hauer writes:
> > On Wed, Feb 18, 2015 at 12:54:18PM +0100, Steffen Trumtrar wrote:
> >> Add support for the Altera SoCFPGA Development Kit.
> >> The setup is based on the GHRD from Altera.
> >> 
> >> index 000000000000..73a5a7481924
> >> --- /dev/null
> >> +++ b/arch/arm/boards/altera-socdk/board.c
> >> @@ -0,0 +1,20 @@
> >> +#include <common.h>
> >> +#include <types.h>
> >> +#include <driver.h>
> >> +#include <init.h>
> >> +#include <asm/armlinux.h>
> >> +#include <linux/micrel_phy.h>
> >> +#include <linux/phy.h>
> >> +#include <linux/sizes.h>
> >> +#include <fcntl.h>
> >> +#include <fs.h>
> >> +#include <mach/socfpga-regs.h>
> >> +
> >> +static int socfpga_console_init(void)
> >> +{
> >> +	if (!of_machine_is_compatible("altr,socdk"))
> >> +		return 0;
> >> +
> >> +	return 0;
> >> +}
> >> +console_initcall(socfpga_console_init);
> >
> > Nothing useful in this file. Better remove it?
> >
> 
> As it turns out, I actually need to call a phyfixup for the board here.
> What would you prefer: Fixup or Resend?

Since I haven't applied it: resend.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-02-23  7:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 11:54 [PATCH 0/3] Socfpga: handoff importer updates + SOCDK support Steffen Trumtrar
2015-02-18 11:54 ` [PATCH 1/3] scripts: add socfpga preloader-files importer Steffen Trumtrar
2015-02-18 23:04   ` Michael Grzeschik
2015-02-18 11:54 ` [PATCH 2/3] scripts: socfpga: add coccinelle magic Steffen Trumtrar
2015-02-18 11:54 ` [PATCH 3/3] ARM: socfpga: add Altera SoCFPGA Development Kit support Steffen Trumtrar
2015-02-19 19:58   ` Sascha Hauer
2015-02-20  7:49     ` Steffen Trumtrar
2015-02-23  7:34       ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150223073416.GK12209@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox