From: Sascha Hauer <s.hauer@pengutronix.de>
To: Doug Brainard <dbrainard@brainardinsight.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] SAMA5D4EK - Now uses the new environment.
Date: Mon, 23 Feb 2015 10:29:03 +0100 [thread overview]
Message-ID: <20150223092903.GM12209@pengutronix.de> (raw)
In-Reply-To: <CA+nEJikidFkrVM+CbqZfFU=Y2EjYKZDz-ug=eVWDh5Y-g0_Gkw@mail.gmail.com>
On Sun, Feb 22, 2015 at 10:58:42AM -0700, Doug Brainard wrote:
> Bo,
>
> On Thu, Feb 12, 2015 at 10:52 PM, Bo Shen <voice.shen@atmel.com> wrote:
> > Hi Doug,
> >
> > On 02/13/2015 01:27 PM, Doug Brainard wrote:
> >>
> >> Switched SAMA5D4EK development board to the newer environment method.
> >>
> >> Improved interface to the new environment
> >>
> >> Create a custom mtdparts-add script to have the partition naming work the
> >> same as in the old environment
> >>
> >> Removed custom mtdparts-add after new patch resolved the issue being seen.
> >
> >
> > I think the upper three line should be under "---", while not in commit
> > message. This is what you do between previous version and this version (So
> > you need add version to the patch).
> >
>
> Is there an official way to add a patch version? And shouldn't
> everything go above the "---" or it will be added to the changed
> files?
>
> >> Signed-off-by: Doug Brainard <dbrainard@brainardinsight.com>
> >> ---
> >
> >
> > (Put the depends here)
> > For example:
> > This patch based on "mtd partition handling updates" patch series from
> > Sascha Hauer <s.hauer@pengutronix.de>
> >
> > (Put change log here)
> >
> > For example:
> > Changes in v2:
> > - Removed custom mtdparts-add after new patch resolved the issue being
> > seen.
> >
>
> To add the depends and change log, do I just edit the patch file with
> a text editor or is there a command argument to do that?
The --annotate option might help you here. I haven't used it before, so
I don't know.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-02-23 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 5:27 Doug Brainard
2015-02-13 5:30 ` Doug Brainard
2015-02-13 5:52 ` Bo Shen
2015-02-15 20:32 ` Doug Brainard
2015-02-16 6:24 ` Sascha Hauer
2015-02-22 17:58 ` Doug Brainard
2015-02-23 9:29 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223092903.GM12209@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dbrainard@brainardinsight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox