mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] tegra: avp_init: write DT address register earlier
@ 2015-03-02 21:47 Lucas Stach
  2015-03-03  7:38 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2015-03-02 21:47 UTC (permalink / raw)
  To: barebox

Otherwise the write would be skipped if we are already running on the main CPU
cluster. In practice this means that a second stage barebox will reuse the DT
of the first stage, instead of using it's own.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
Sascha, it would be nice if you could squeeze into master as this is
clearly a simple bugfix.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/mach-tegra/tegra_avp_init.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-tegra/tegra_avp_init.c b/arch/arm/mach-tegra/tegra_avp_init.c
index 619fecf..91fd894 100644
--- a/arch/arm/mach-tegra/tegra_avp_init.c
+++ b/arch/arm/mach-tegra/tegra_avp_init.c
@@ -262,6 +262,9 @@ void tegra_avp_reset_vector(uint32_t boarddata)
 	int num_cores;
 	unsigned int entry_address = 0;
 
+	/* put boarddata in scratch reg, for main CPU to fetch after startup */
+	writel(boarddata, TEGRA_PMC_BASE + PMC_SCRATCH(10));
+
 	if (tegra_cpu_is_maincomplex())
 		tegra_maincomplex_entry();
 
@@ -291,9 +294,6 @@ void tegra_avp_reset_vector(uint32_t boarddata)
 	}
 	writel(entry_address, TEGRA_EXCEPTION_VECTORS_BASE + 0x100);
 
-	/* put boarddata in scratch reg, for main CPU to fetch after startup */
-	writel(boarddata, TEGRA_PMC_BASE + PMC_SCRATCH(10));
-
 	/* bring up main CPU complex */
 	start_cpu0_clocks();
 	maincomplex_powerup();
-- 
2.1.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] tegra: avp_init: write DT address register earlier
  2015-03-02 21:47 [PATCH] tegra: avp_init: write DT address register earlier Lucas Stach
@ 2015-03-03  7:38 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-03-03  7:38 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Mon, Mar 02, 2015 at 10:47:20PM +0100, Lucas Stach wrote:
> Otherwise the write would be skipped if we are already running on the main CPU
> cluster. In practice this means that a second stage barebox will reuse the DT
> of the first stage, instead of using it's own.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> Sascha, it would be nice if you could squeeze into master as this is
> clearly a simple bugfix.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-03  7:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-02 21:47 [PATCH] tegra: avp_init: write DT address register earlier Lucas Stach
2015-03-03  7:38 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox