Re: [PATCH 7/7] command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 06:43 Wed 11 Mar     , Sascha Hauer wrote:
> On Tue, Mar 10, 2015 at 03:28:17PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > pass the key via -k param
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  commands/digest.c | 26 ++++++++++++++++++++++----
> >  common/digest.c   | 22 +++++++++++++++++-----
> >  include/digest.h  |  3 +++
> >  3 files changed, 42 insertions(+), 9 deletions(-)
> > 
> > diff --git a/commands/digest.c b/commands/digest.c
> > index 20fa13f..713f5c6 100644
> > --- a/commands/digest.c
> > +++ b/commands/digest.c
> > @@ -25,6 +25,7 @@
> >  #include <xfuncs.h>
> >  #include <malloc.h>
> >  #include <digest.h>
> > +#include <getopt.h>
> >  
> >  static int do_digest(char *algorithm, int argc, char *argv[])
> >  {
> > @@ -32,11 +33,26 @@ static int do_digest(char *algorithm, int argc, char *argv[])
> >  	int ret = 0;
> >  	int i;
> >  	unsigned char *hash;
> > +	unsigned char *key = NULL;
> > +	size_t keylen = 0;
> > +	int opt;
> > +
> > +	while((opt = getopt(argc, argv, "k:")) > 0) {
> > +		switch(opt) {
> > +		case 'k':
> > +			key = optarg;
> > +			keylen = strlen(key);
> > +			break;
> > +		}
> 
> This passes the key directly as string to the digest operations. This
> means we are limited to ASCII printable strings here. I'm not very
> familiar with ways for passing keys, but shouldn't we allow to pass the
> key as hex numbers or similar?
for hmac yes

for other not really but il will be an1n x509 and others

so we will hanld elater

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox