From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YVf52-0007K3-4n for barebox@lists.infradead.org; Wed, 11 Mar 2015 11:45:41 +0000 Date: Wed, 11 Mar 2015 12:45:18 +0100 From: Sascha Hauer Message-ID: <20150311114518.GU24885@pengutronix.de> References: <20150310141659.GH30554@ns203013.ovh.net> <1425997697-27467-1-git-send-email-plagnioj@jcrosoft.com> <1425997697-27467-2-git-send-email-plagnioj@jcrosoft.com> <20150311053242.GL24885@pengutronix.de> <20150311102654.GJ30554@ns203013.ovh.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150311102654.GJ30554@ns203013.ovh.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/7] digest: make it multi-instance To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Wed, Mar 11, 2015 at 11:44:48AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 06:32 Wed 11 Mar , Sascha Hauer wrote: > > On Tue, Mar 10, 2015 at 03:28:12PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > Now you need to call digest_alloc and when you finish to use it digest_free. > > > > > > We need this for upcomming aes encryption support and secure boot > > > as we will need multiple instance of the same digest. > > > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > > --- > > > > > +struct digest* digest_alloc(char* name) > > > +{ > > > + struct digest* d; > > > + struct digest_algo* algo; > > > + > > > + algo = digest_algo_get_by_name(name); > > > + if (!algo) > > > + return NULL; > > > + > > > + d = xzalloc(sizeof(*d)); > > > + d->algo = algo; > > > + d->ctx = xzalloc(algo->ctx_length); > > > > > > I would pretty much prefer to delegate the allocation to the digest_algo > > via an algo->alloc() function. The algo specific allocation function > > could then embed struct digest into a bigger struct and use > > container_of() to get its private data. No need for d->ctx and > > algo->ctx_length then. > > > > even in linux we did allocate the ctx at framework level > > this will reduce the binary size at the end just few bytes maybe but > few bytes everywhere make kiB as did Mazda on then new mx-5 Ok, then let's hope this is really smaller in binary size. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox