[PATCH 1/4] ARM: highbank: fix build with recent binutils

[PATCH 1/4] ARM: highbank: fix build with recent binutils

[Lucas Stach]

Recent binutils versions assume that the v7 security
extensions are not available by default. They need to be enabled
explicitly if code wishes to use instructions defined by them.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-highbank/smc.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-highbank/smc.S b/arch/arm/mach-highbank/smc.S
index b2118b4a84bf..cc932a393166 100644
--- a/arch/arm/mach-highbank/smc.S
+++ b/arch/arm/mach-highbank/smc.S
@@ -18,6 +18,7 @@
  */
 
 ENTRY(highbank_smc1)
+	.arch_extension sec
 	stmfd	sp!, {r4-r11, lr}
 	mov	r12, r0
 	mov	r0, r1
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/4] clk: fractional-divider: fix build with CONFIG_MODULES

[Lucas Stach]

Fixes:
error: 'clk_register_fractional_divider' undeclared here

introduced with commit 22a0c31c9265 (CLK: Add fractional
divider clock support from Linux kernel)

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/clk/clk-fractional-divider.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c
index 59b98aac9eb7..1504f7a72868 100644
--- a/drivers/clk/clk-fractional-divider.c
+++ b/drivers/clk/clk-fractional-divider.c
@@ -149,4 +149,4 @@ struct clk *clk_fractional_divider(
 
 	return fd;
 }
-EXPORT_SYMBOL_GPL(clk_register_fractional_divider);
+EXPORT_SYMBOL_GPL(clk_fractional_divider);
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/4] ARM: highbank: select OFTREE

[Lucas Stach]

The board code uses quite a few OF functions and it doesn't seem
reasonable to run this board without DT support.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-highbank/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
index 950810b57517..8af480861c3f 100644
--- a/arch/arm/mach-highbank/Kconfig
+++ b/arch/arm/mach-highbank/Kconfig
@@ -9,6 +9,7 @@ choice
 
 config MACH_HIGHBANK
 	bool "Calxeda Highbank"
+	select OFTREE
 	select HAVE_DEFAULT_ENVIRONMENT_NEW
 
 endchoice
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 4/4] usb: host: xhci: depend on HAS_DMA

[Lucas Stach]

The driver needs the dma coherent function and thus can
only work on architectures implementing them.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/usb/host/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 12a090c5cc7c..54eaf468b7a0 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -26,6 +26,7 @@ endif
 
 config USB_XHCI
 	bool "xHCI driver"
+	depends on HAS_DMA
 	help
 	  The eXtensible Host Controller Interface (xHCI) is standard for
 	  USB 3.0 "SuperSpeed" host controller hardware. xHCI specification
@@ -37,6 +38,7 @@ config USB_XHCI
 
 config USB_XHCI_PCI
 	depends on PCI
+	depends on HAS_DMA
 	select USB_XHCI
 	bool "PCI xHCI driver"
 	help
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 3/4] ARM: highbank: select OFTREE

[Jean-Christophe PLAGNIOL-VILLARD]

> On Mar 26, 2015, at 4:57 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> 
> The board code uses quite a few OF functions and it doesn't seem
> reasonable to run this board without DT support.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm/mach-highbank/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
> index 950810b57517..8af480861c3f 100644
> --- a/arch/arm/mach-highbank/Kconfig
> +++ b/arch/arm/mach-highbank/Kconfig
> @@ -9,6 +9,7 @@ choice
> 
> config MACH_HIGHBANK
> 	bool "Calxeda Highbank"
> +	select OFTREE
> 	select HAVE_DEFAULT_ENVIRONMENT_NEW

you can run wihtout it as the oftree code is only used if you decide to use the dtb provided by the
firmware

as example on qemu

so nack on this one

Best Regards,
J.
> 
> endchoice
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 3/4] ARM: highbank: select OFTREE

[Sascha Hauer]

On Thu, Mar 26, 2015 at 11:58:12AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> > On Mar 26, 2015, at 4:57 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > 
> > The board code uses quite a few OF functions and it doesn't seem
> > reasonable to run this board without DT support.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > arch/arm/mach-highbank/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
> > index 950810b57517..8af480861c3f 100644
> > --- a/arch/arm/mach-highbank/Kconfig
> > +++ b/arch/arm/mach-highbank/Kconfig
> > @@ -9,6 +9,7 @@ choice
> > 
> > config MACH_HIGHBANK
> > 	bool "Calxeda Highbank"
> > +	select OFTREE
> > 	select HAVE_DEFAULT_ENVIRONMENT_NEW
> 
> you can run wihtout it as the oftree code is only used if you decide to use the dtb provided by the
> firmware

With CONFIG_OFTREE disabled the board fails to link:

arch/arm/boards/built-in.o: In function `highbank_mem_init':
:(.text.highbank_mem_init+0x10): undefined reference to `of_unflatten_dtb'
arch/arm/boards/built-in.o: In function `highbank_devices_init':
:(.text.highbank_devices_init+0x54): undefined reference to `of_get_fixed_tree'

Even if we had a static inline no-op wrapper for of_get_fixed_tree, the
board doesn't check the return value of of_get_fixed_tree and does this:

	fdt = of_get_fixed_tree(NULL);
	add_mem_device("dtb", (unsigned long)fdt, be32_to_cpu(fdt->totalsize),
	       IORESOURCE_MEM_WRITEABLE);

Here the code would crash with a NULL pointer derefence. So unless we
get a couple of other patches I believe Lucas' patch is correct.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/4] ARM: highbank: fix build with recent binutils

[Sascha Hauer]

On Wed, Mar 25, 2015 at 09:57:39PM +0100, Lucas Stach wrote:
> Recent binutils versions assume that the v7 security
> extensions are not available by default. They need to be enabled
> explicitly if code wishes to use instructions defined by them.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/mach-highbank/smc.S | 1 +
>  1 file changed, 1 insertion(+)

Applied the non controversal patches for now.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 3/4] ARM: highbank: select OFTREE

[Lucas Stach]

Am Donnerstag, den 26.03.2015, 07:59 +0100 schrieb Sascha Hauer:
> On Thu, Mar 26, 2015 at 11:58:12AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > 
> > > On Mar 26, 2015, at 4:57 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > > 
> > > The board code uses quite a few OF functions and it doesn't seem
> > > reasonable to run this board without DT support.
> > > 
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > > arch/arm/mach-highbank/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
> > > index 950810b57517..8af480861c3f 100644
> > > --- a/arch/arm/mach-highbank/Kconfig
> > > +++ b/arch/arm/mach-highbank/Kconfig
> > > @@ -9,6 +9,7 @@ choice
> > > 
> > > config MACH_HIGHBANK
> > > 	bool "Calxeda Highbank"
> > > +	select OFTREE
> > > 	select HAVE_DEFAULT_ENVIRONMENT_NEW
> > 
> > you can run wihtout it as the oftree code is only used if you decide to use the dtb provided by the
> > firmware
> 
> With CONFIG_OFTREE disabled the board fails to link:
> 
> arch/arm/boards/built-in.o: In function `highbank_mem_init':
> :(.text.highbank_mem_init+0x10): undefined reference to `of_unflatten_dtb'
> arch/arm/boards/built-in.o: In function `highbank_devices_init':
> :(.text.highbank_devices_init+0x54): undefined reference to `of_get_fixed_tree'
> 
> Even if we had a static inline no-op wrapper for of_get_fixed_tree, the
> board doesn't check the return value of of_get_fixed_tree and does this:
> 
> 	fdt = of_get_fixed_tree(NULL);
> 	add_mem_device("dtb", (unsigned long)fdt, be32_to_cpu(fdt->totalsize),
> 	       IORESOURCE_MEM_WRITEABLE);
> 
> Here the code would crash with a NULL pointer derefence. So unless we
> get a couple of other patches I believe Lucas' patch is correct.

As Jean-Christophe has not indicated that he is going to fix this
another way, could you please take this patch?

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 3/4] ARM: highbank: select OFTREE

[Sascha Hauer]

On Mon, Apr 20, 2015 at 10:51:30AM +0200, Lucas Stach wrote:
> Am Donnerstag, den 26.03.2015, 07:59 +0100 schrieb Sascha Hauer:
> > On Thu, Mar 26, 2015 at 11:58:12AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > 
> > > > On Mar 26, 2015, at 4:57 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > > > 
> > > > The board code uses quite a few OF functions and it doesn't seem
> > > > reasonable to run this board without DT support.
> > > > 
> > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > > ---
> > > > arch/arm/mach-highbank/Kconfig | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
> > > > index 950810b57517..8af480861c3f 100644
> > > > --- a/arch/arm/mach-highbank/Kconfig
> > > > +++ b/arch/arm/mach-highbank/Kconfig
> > > > @@ -9,6 +9,7 @@ choice
> > > > 
> > > > config MACH_HIGHBANK
> > > > 	bool "Calxeda Highbank"
> > > > +	select OFTREE
> > > > 	select HAVE_DEFAULT_ENVIRONMENT_NEW
> > > 
> > > you can run wihtout it as the oftree code is only used if you decide to use the dtb provided by the
> > > firmware
> > 
> > With CONFIG_OFTREE disabled the board fails to link:
> > 
> > arch/arm/boards/built-in.o: In function `highbank_mem_init':
> > :(.text.highbank_mem_init+0x10): undefined reference to `of_unflatten_dtb'
> > arch/arm/boards/built-in.o: In function `highbank_devices_init':
> > :(.text.highbank_devices_init+0x54): undefined reference to `of_get_fixed_tree'
> > 
> > Even if we had a static inline no-op wrapper for of_get_fixed_tree, the
> > board doesn't check the return value of of_get_fixed_tree and does this:
> > 
> > 	fdt = of_get_fixed_tree(NULL);
> > 	add_mem_device("dtb", (unsigned long)fdt, be32_to_cpu(fdt->totalsize),
> > 	       IORESOURCE_MEM_WRITEABLE);
> > 
> > Here the code would crash with a NULL pointer derefence. So unless we
> > get a couple of other patches I believe Lucas' patch is correct.
> 
> As Jean-Christophe has not indicated that he is going to fix this
> another way, could you please take this patch?

Did that

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox