mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512
Date: Fri, 3 Apr 2015 08:15:18 +0200	[thread overview]
Message-ID: <20150403061518.GN9742@pengutronix.de> (raw)
In-Reply-To: <CAOpc7mHqV-qLrpK2Kaus3q3shPTnjWeCw4wozA6b4b6s5=Sy-A@mail.gmail.com>

On Thu, Apr 02, 2015 at 09:11:33AM +0200, Holger Schurig wrote:
> Antony,
> 
> that git has such a function doesn't mean that it is usable in any git
> project. I too, like Jean-Christophe, that a style issue shouldn't be
> named as a fix,

The patch Antony sent has been generated with git commit --fixup. I'll
apply it to the appropriate branch and run a git rebase --autosquash
over it. This makes it very easy for Antony to generate this patch and
easy for me to find and fixup the correct patch. We could also use
--squash instead of --fixup. That would keep both commit messages,
but that might be desirable.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2015-04-03  6:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 16:23 Antony Pavlov
2015-03-28 20:07 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-29  8:04   ` Antony Pavlov
2015-04-02  7:11     ` Holger Schurig
2015-04-02  7:27       ` Antony Pavlov
2015-04-03  6:15       ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150403061518.GN9742@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=holgerschurig@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox