From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] make PBL_CONSOLE depend on PBL_IMAGE
Date: Mon, 13 Apr 2015 10:17:57 +0200 [thread overview]
Message-ID: <20150413081757.GF9742@pengutronix.de> (raw)
In-Reply-To: <1428156197-5305-1-git-send-email-antonynpavlov@gmail.com>
On Sat, Apr 04, 2015 at 05:03:17PM +0300, Antony Pavlov wrote:
> PBL_CONSOLE option is used only for building PBL. See this output:
>
> barebox$ git grep PBL_CONSOLE
> arch/arm/configs/tx28stk5_defconfig:CONFIG_PBL_CONSOLE=y
> common/Kconfig:config PBL_CONSOLE
> common/Makefile:pbl-$(CONFIG_PBL_CONSOLE) += memory_display.o
> include/printk.h: (defined(__PBL__) && defined(CONFIG_PBL_CONSOLE))
> include/stdio.h: (defined(__PBL__) && defined(CONFIG_PBL_CONSOLE))
> lib/Makefile:pbl-$(CONFIG_PBL_CONSOLE) += vsprintf.o
> pbl/Makefile:pbl-$(CONFIG_PBL_CONSOLE) += console.o
>
> PBL_CONSOLE looks confusing in PBL-less configuration
> so it's better to enable it only if PBL is enabled.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> common/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-04-13 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 14:03 Antony Pavlov
2015-04-13 8:17 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413081757.GF9742@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox