Re: [PATCH] barebox update: add note after successful update

[Stefan Christ <s.christ@phytec.de>]

On Fri, May 22, 2015 at 08:50:37AM +0200, Sascha Hauer wrote:
> On Thu, May 21, 2015 at 09:41:49AM +0200, Stefan Christ wrote:
> > Some users of the barebox_update command forget to erase the external
> > barebox environment after updating the barebox. Using an old barebox
> > environment leads to various problems if there were major changes.
> > 
> > So add a gentle reminder after the successful update.
> > 
> > Signed-off-by: Stefan Christ <s.christ@phytec.de>
> > ---
> >  common/bbu.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/common/bbu.c b/common/bbu.c
> > index 7fb154a..1b125e9 100644
> > --- a/common/bbu.c
> > +++ b/common/bbu.c
> > @@ -113,8 +113,11 @@ int barebox_update(struct bbu_data *data)
> >  	if (ret == -EINTR)
> >  		printf("update aborted\n");
> >  
> > -	if (!ret)
> > +	if (!ret) {
> >  		printf("update succeeded\n");
> > +		if (IS_ENABLED(CONFIG_ENV_HANDLING))
> > +			printf("You maybe want to erase the barebox environment.\n");
> 
> How about adding a hint ...using saveenv -z?

Oh, I didn't know that the "-z" argument exits. Nice.

Ok, but what about the situation when a user boots the barebox from sdcard and
uses the barebox_update handler to flash a barebox to NAND. In such case
'saveenv -z' overwrites the environment on the sdcard.

I've struggled a bit to come up with a short text that covers all these cases.

Mit freundlichen Grüßen / Kind regards,
	Stefan Christ

> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox