mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 2/2] i2c: omap: fix i2c bus number output
@ 2015-06-02 19:03 Robert Schwebel
  2015-06-03  7:56 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Robert Schwebel @ 2015-06-02 19:03 UTC (permalink / raw)
  To: barebox

When probing from devicetree, the output for several i2c host
controllers prints out a bus number of -1:

i2c-omap 44e0b000.i2c: bus -1 rev0.11 at 400 kHz
i2c-omap 4802a000.i2c: bus -1 rev0.11 at 400 kHz
i2c-omap 4819c000.i2c: bus -1 rev0.11 at 400 kHz

The call to i2c_add_numbered_adapter() in probe finds out the next free
bus number, so we move the output to a location where the number is
already determined.

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
 drivers/i2c/busses/i2c-omap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 4308963..330db98 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1091,9 +1091,6 @@ i2c_omap_probe(struct device_d *pdev)
 	/* reset ASAP, clearing any IRQs */
 	omap_i2c_init(i2c_omap);
 
-	dev_info(pdev, "bus %d rev%d.%d at %d kHz\n",
-		 pdev->id, major, minor, i2c_omap->speed);
-
 	omap_i2c_idle(i2c_omap);
 
 	i2c_omap->adapter.master_xfer = omap_i2c_xfer,
@@ -1108,6 +1105,9 @@ i2c_omap_probe(struct device_d *pdev)
 		goto err_unuse_clocks;
 	}
 
+	dev_info(pdev, "bus %d rev%d.%d at %d kHz\n",
+		 i2c_omap->adapter.nr, major, minor, i2c_omap->speed);
+
 	return 0;
 
 err_unuse_clocks:
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] i2c: omap: fix i2c bus number output
  2015-06-02 19:03 [PATCH 2/2] i2c: omap: fix i2c bus number output Robert Schwebel
@ 2015-06-03  7:56 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-06-03  7:56 UTC (permalink / raw)
  To: Robert Schwebel; +Cc: barebox

On Tue, Jun 02, 2015 at 09:03:51PM +0200, Robert Schwebel wrote:
> When probing from devicetree, the output for several i2c host
> controllers prints out a bus number of -1:
> 
> i2c-omap 44e0b000.i2c: bus -1 rev0.11 at 400 kHz
> i2c-omap 4802a000.i2c: bus -1 rev0.11 at 400 kHz
> i2c-omap 4819c000.i2c: bus -1 rev0.11 at 400 kHz
> 
> The call to i2c_add_numbered_adapter() in probe finds out the next free
> bus number, so we move the output to a location where the number is
> already determined.
> 
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
>  drivers/i2c/busses/i2c-omap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-03  7:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-02 19:03 [PATCH 2/2] i2c: omap: fix i2c bus number output Robert Schwebel
2015-06-03  7:56 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox