mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wadim Egorov <w.egorov@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: Set the actual ethaddr in register_preset_mac_address()
Date: Wed, 10 Jun 2015 06:32:37 +0200	[thread overview]
Message-ID: <20150610043237.GT6325@pengutronix.de> (raw)
In-Reply-To: <1433833465-6569-1-git-send-email-w.egorov@phytec.de>

Hi Wadim,

On Tue, Jun 09, 2015 at 09:04:25AM +0200, Wadim Egorov wrote:
> Set the ethaddr for the current edev.
> 
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
>  net/eth.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/eth.c b/net/eth.c
> index 89bddba..03e0a2e 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -49,6 +49,7 @@ static void register_preset_mac_address(struct eth_device *edev, const char *eth
>  	ethaddr_to_string(ethaddr, ethaddr_str);
>  
>  	if (is_valid_ether_addr(ethaddr)) {
> +		memcpy(edev->ethaddr, ethaddr, 6);
>  		dev_info(&edev->dev, "got preset MAC address: %s\n", ethaddr_str);
>  		dev_set_param(&edev->dev, "ethaddr", ethaddr_str);
>  	}

In which case is this necessary? Normally a dev_set_param on "ethaddr"
should already set edev->ethaddr, there should be no need to copy this
manually.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-06-10  4:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  7:04 Wadim Egorov
2015-06-10  4:32 ` Sascha Hauer [this message]
2015-06-10  6:44   ` Wadim Egorov
2015-06-10 11:28     ` AW: " Gabor Janak (g.janak@agilion.de)
2015-06-15  6:55     ` Sascha Hauer
2015-06-15  9:08       ` Wadim Egorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150610043237.GT6325@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox