[RFC] add decode command (SPD EEPROM data decoder)

[RFC] add decode command (SPD EEPROM data decoder)

[Alexander Smirnov]

decode-dimms perl script is used as prototype
(see https://github.com/groeck/i2c-tools/blob/master/eeprom/decode-dimms).

Here is a sample decode output:

barebox@barebox sandbox:/ decode env/crucial_pc2-6400_ddr2
Decoding EEPROM: env/crucial_pc2-6400_ddr2

---=== SPD EEPROM Information ===---
EEPROM Checksum of bytes 0-62			 OK (0xCA)
Total number of bytes in EEPROM			 256
Fundamental Memory type				 DDR2 SDRAM
SPD Revision					 1.3

---=== Memory Characteristics ===---
Maximum module speed				 800 MHz (PC2-6400)
Size						 1024 MB
Banks x Rows x Columns x Bits			 8 x 14 x 10 x 64
Ranks						 1
SDRAM Device Width				 8 bits
Module Height					 30.0 mm
Module Type					 SO-DIMM (67.6 mm)
DRAM Package					 Planar
Voltage Interface Level				 SSTL 1.8V
Module Configuration Type 			 No Parity
Refresh Rate					 Reduced (7.8 us) - Self Refresh
Supported Burst Lengths				 4, 8
Supported CAS Latencies (tCL)			 6T
tCL-tRCD-tRP-tRAS				 6-6-6-18 as DDR2-800
Minimum Cycle Time				 250 (ns*100) at CAS 6
Maximum Access Time				 4 (ns*10) at CAS 6
Maximum Cycle Time (tCK max)			 8 ns

---=== Timing Parameters ===---
Address/Command Setup Time Before Clock (tIS)	 17 (ns*100)
Address/Command Hold Time After Clock (tIH)	 25 (ns*100)
Data Input Setup Time Before Strobe (tDS)	 5 (ns*100)
Data Input Hold Time After Strobe (tDH)		 12 (ns*100)
Minimum Row Precharge Delay (tRP)		 150 (ns*10)
Minimum Row Active to Row Active Delay (tRRD)	 75 (ns*10)
Minimum RAS# to CAS# Delay (tRCD)		 150 (ns*10)
Minimum RAS# Pulse Width (tRAS)			 450 (ns*10)
Write Recovery Time (tWR)			 150 (ns*10)
Minimum Write to Read CMD Delay (tWTR)		 75 (ns*10)
Minimum Read to Pre-charge CMD Delay (tRTP)	 75 (ns*10)
Minimum Active to Auto-refresh Delay (tRC)	 600 (ns*10)
Minimum Recovery Delay (tRFC)			 1270 (ns*10)
Maximum DQS to DQ Skew (tDQSQ)			 20 (ns*100)
Maximum Read Data Hold Skew (tQHS)		 30 (ns*100)

---=== Manufacturing Information ===---
Manufacturer JEDEC ID				 7f 7f 7f 7f 7f 9b 00 00
Part Number					 CT12864AC800.M8FM8
Manufacturing Date				 2014-W24
Assembly Serial Number				 0x00000000

TODOs:

  * Timing Parameters section output format is slightly
    differ from decode-dimms' format;
  * supports only DDR2 SPD EEPROM.

Signed-off-by: Smirnov Alexander <alllecs@yandex.ru>
---
 commands/Kconfig  |   6 +
 commands/Makefile |   1 +
 commands/decode.c | 328 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 335 insertions(+)

diff --git a/commands/Kconfig b/commands/Kconfig
index bb6674e..f0e0b75 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -2102,6 +2102,12 @@ config CMD_STATE
 	depends on STATE
 	prompt "state"
 
+config CMD_DECODE
+	tristate
+	prompt "decode"
+	help
+	  decode spd eeprom
+
 # end Miscellaneous commands
 endmenu
 
diff --git a/commands/Makefile b/commands/Makefile
index 3698347..71cd877 100644
--- a/commands/Makefile
+++ b/commands/Makefile
@@ -112,3 +112,4 @@ obj-$(CONFIG_CMD_NV)		+= nv.o
 obj-$(CONFIG_CMD_DEFAULTENV)	+= defaultenv.o
 obj-$(CONFIG_CMD_STATE)		+= state.o
 obj-$(CONFIG_CMD_DHCP)		+= dhcp.o
+obj-$(CONFIG_CMD_DECODE)	+= decode.o
diff --git a/commands/decode.c b/commands/decode.c
new file mode 100644
index 0000000..7294b11
--- /dev/null
+++ b/commands/decode.c
@@ -0,0 +1,328 @@
+#include <fcntl.h>
+#include <common.h>
+#include <getopt.h>
+#include <command.h>
+#include <envfs.h>
+#include <errno.h>
+#include <fs.h>
+#include <libfile.h>
+#include <malloc.h>
+#include <globalvar.h>
+#include <stdlib.h>
+#include <stdio.h>
+
+#ifndef __BAREBOX__
+static inline int fls(int x)
+{
+       int r = 32;
+ 
+        if (!x)
+                return 0;
+         if (!(x & 0xffff0000u)) {
+                x <<= 16;
+                r -= 16;
+        }
+        if (!(x & 0xff000000u)) {
+                x <<= 8;
+                r -= 8;
+        }
+        if (!(x & 0xf0000000u)) {
+                x <<= 4;
+                r -= 4;
+        }
+        if (!(x & 0xc0000000u)) {
+                x <<= 2;
+                r -= 2;
+        }
+        if (!(x & 0x80000000u)) {
+                x <<= 1;
+                r -= 1;
+        }
+        return r;
+}
+#endif
+
+char *heights[] = {
+	"<25.4",
+	"25.4",
+	"25.4 - 30.0",
+	"30.0",
+	"30.5",
+	"> 30.5"
+};
+
+char *sdram_voltage_interface_level[] = {
+	"TTL (5V tolerant)",
+	"LVTTL (not 5V tolerant)",
+	"HSTL 1.5V",
+	"SSTL 3.3V",
+	"SSTL 2.5V",
+	"SSTL 1.8V"
+};
+
+char *ddr2_module_types[] = {
+	"RDIMM (133.35 mm)",
+	"UDIMM (133.25 mm)",
+	"SO-DIMM (67.6 mm)",
+	"Micro-DIMM (45.5 mm)",
+	"Mini-RDIMM (82.0 mm)",
+	"Mini-UDIMM (82.0 mm)"
+};
+
+char *refresh[] = {
+	"15.625",
+	"3.9",
+	"7.8",
+	"31.3",
+	"62.5",
+	"125"
+};
+
+char *type_list[] = {
+	"Reserved",
+	"FPM DRAM",
+	"EDO",
+	"Pipelined Nibble",
+	"SDR SDRAM",
+	"Multiplexed ROM",
+	"DDR SGRAM",
+	"DDR SDRAM",
+	"DDR2 SDRAM",
+	"FB-DIMM",
+	"FB-DIMM Probe",
+	"DDR3 SDRAM"
+};
+
+int funct(uint8_t addr)
+{
+	int t;
+
+	t = ((addr >> 4) * 10 + (addr & 0xf));
+
+	return t;
+}
+
+int ddr2_sdram_atime(uint8_t addr)
+{
+	int t;
+
+//	t = ((addr >> 4) * 0.1 + (addr & 0xf) * 0.01);
+	t = ((addr >> 4) + (addr & 0xf));
+
+	return t;
+}
+
+void dump(uint8_t *addr, int len)
+{
+	int i;
+
+	printf("\t 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f\n\n");
+
+	for (i = 0; i < len; i++) {
+		if ((i % 0x10) == 0x00) {
+			printf("%07x:", i);
+		}
+		printf(" %02x", addr[i]);
+		if ((i % 0x10) == 0xf) {
+			printf("\n");
+		}
+	}
+
+	printf("\n");
+}
+
+int ddr2_sdram_ctime(uint8_t byte)
+{
+	int ctime;
+
+	ctime = (byte >> 4) * 100;
+	if ((byte & 0xf) <= 9) {
+		ctime += (byte & 0xf) * 10;
+	} else if ((byte & 0xf) == 10) {
+		ctime += 25;
+	} else if ((byte & 0xf) == 11) {
+		ctime += 33;
+	} else if ((byte & 0xf) == 12) {
+		ctime += 66;
+	} else if ((byte & 0xf) == 13) {
+		ctime += 75;
+	}
+	return ctime;
+}
+
+static int do_decode(int argc, char *argv[])
+{
+	int highestCAS = 0;
+	int cas[256];
+	int i, i_i, k;
+	int ddrclk, tbits, pcclk;
+	int trcd, trp, tras;
+	int ctime;
+	int fp;
+	uint8_t record[256];
+	uint8_t parity;
+	char *ref;
+
+	if (argc != 2) {
+		printf("Отсутствует или указано больше 1 аргумента\n");
+		return 2;
+	}
+
+	fp = open(argv[1], O_RDONLY);
+
+	if (fp == 0) {
+		perror("Ошибка при работе с файлом");
+		return 3;
+	}
+
+	read(fp, &record[0], 256);
+	close(fp);
+
+//	dump(&record[0], 256);
+
+	printf("Decoding EEPROM: %s\n\n", argv[1]);
+
+	printf("---=== SPD EEPROM Information ===---\n");
+	printf("EEPROM Checksum of bytes 0-62\t\t\t OK (0x%0X)\n", record[63]);
+	printf("# of bytes written to SDRAM EEPROM\t\t %d\n", record[0]);
+	printf("Total number of bytes in EEPROM\t\t\t %d\n", 1 << record[1]);
+
+	if (record[2] < 11) {
+		printf("Fundamental Memory type\t\t\t\t %s\n", type_list[record[2]]);
+	} else {
+		printf("Warning: unknown memory type (%02x)\n", record[2]);
+	}
+	printf("SPD Revision\t\t\t\t\t %x.%x\n", record[62] >> 4, record[62] & 0x0f);
+
+	printf("\n---=== Memory Characteristics ===---\n");
+
+	ctime = ddr2_sdram_ctime(record[9]);
+	ddrclk = 2 * (1000 / ctime) * 100;
+	tbits = (record[7] << 8) + record[6];
+	if ((record[11] & 0x03) == 1) {
+		tbits = tbits - 8;
+	}
+	pcclk = ddrclk * tbits / 8;
+	pcclk = pcclk - (pcclk % 100);
+	printf("Maximum module speed\t\t\t\t %d MHz (PC2-%d)\n", ddrclk, pcclk);
+	i_i= (record[3] & 0x0f) + (record[4] & 0x0f) - 17;
+	k = ((record[5] & 0x7) + 1) * record[17];
+
+	if (i_i > 0 && i_i <= 12 && k > 0) {
+		printf("Size\t\t\t\t\t\t %d MB\n", ((1 << i_i) * k));
+	} else {
+		printf("Size\t\t\t\t\t\t INVALID: %02x %02x %02x %02x\n", record[3], record[4], record[5], record[17]);
+	}
+	printf("Banks x Rows x Columns x Bits\t\t\t %d x %d x %d x %d\n", record[17], record[3], record[4], record[6]);
+	printf("Ranks\t\t\t\t\t\t %d\n", (record[5] & 0x7) + 1);
+	printf("SDRAM Device Width\t\t\t\t %d bits\n", record[13]);
+
+	if ((record[5] >> 5) < 7) {
+		printf("Module Height\t\t\t\t\t %s mm\n", heights[(record[5] >> 5)]);
+	} else {
+		printf("Error height\n");
+	}
+	printf("Module Type\t\t\t\t\t %s\n", ddr2_module_types[fls(record[20]) - 1]);
+	printf("DRAM Package\t\t\t\t\t ");
+	if ((record[5] & 0x10) == 1) {
+		printf("Stack\n");
+	} else {
+		printf("Planar\n");
+	}
+	if (record[8] < 7) {
+		printf("Voltage Interface Level\t\t\t\t %s\n", sdram_voltage_interface_level[record[8]]);
+	} else {
+		printf("Error Voltage Interface Level\n");
+	}
+	printf("Module Configuration Type \t\t\t ");
+
+	parity = record[11] & 0x07;
+	
+	if (parity == 0) {
+		printf("No Parity\n");
+	}
+	if ((parity & 0x03) == 0x01) {
+		printf("Data Parity\n");
+	}
+	if (parity & 0x02) {
+		printf("Data ECC\n");
+	}
+	if (parity & 0x04) {
+                printf("Address/Command Parity\n");
+        }
+
+	if ((record[12] >> 7) == 1) {
+		ref = "- Self Refresh";
+	} else {
+		ref = " ";
+	}
+	printf("Refresh Rate\t\t\t\t\t Reduced (%s us) %s\n", refresh[record[12] & 0x7f], ref);
+	printf("Supported Burst Lengths\t\t\t\t %d, %d\n", record[16] & 4, record[16] & 8);
+
+	trcd = ((record[29] >> 2) + ((record[29] & 3) * 0.25)) / ctime * 100;
+	trp = ((record[27] >> 2) + ((record[27] & 3) * 0.25)) / ctime * 100;
+	tras = record[30] * 100 / ctime ;
+
+	for (i_i = 2; i_i < 7; i_i++) {
+		if (record[18] & (1 << i_i)) {
+			highestCAS = i_i;
+			cas[highestCAS]++;
+		}
+	}
+
+	printf("Supported CAS Latencies (tCL)\t\t\t %dT\n", highestCAS);
+	printf("tCL-tRCD-tRP-tRAS\t\t\t\t %d-%d-%d-%d as DDR2-%d\n", highestCAS, trcd, trp, tras, ddrclk);
+	printf("Minimum Cycle Time\t\t\t\t %d (ns*10) at CAS %d\n", ctime / 10, highestCAS);
+	printf("Maximum Access Time\t\t\t\t %d (ns*10) at CAS %d\n", ddr2_sdram_atime(record[10]), highestCAS);
+	printf("Maximum Cycle Time (tCK max)\t\t\t %d ns\n", (record[43] >> 4) + (record[43] & 0x0f));
+
+	printf("\n---=== Timing Parameters ===---\n");
+	printf("Address/Command Setup Time Before Clock (tIS)\t %d (ns*100)\n", (funct(record[32])));
+	printf("Address/Command Hold Time After Clock (tIH)\t %d (ns*100)\n", (funct(record[33])));
+	printf("Data Input Setup Time Before Strobe (tDS)\t %d (ns*100)\n", (funct(record[34])));
+	printf("Data Input Hold Time After Strobe (tDH)\t\t %d (ns*100)\n", (funct(record[35])));
+
+	printf("Minimum Row Precharge Delay (tRP)\t\t %d (ns*10)\n", (record[27] & 0xfc) * 10 / 4);
+	printf("Minimum Row Active to Row Active Delay (tRRD)\t %d (ns*10)\n", record[28]  * 10 / 4);
+	printf("Minimum RAS# to CAS# Delay (tRCD)\t\t %d (ns*10)\n", (record[29] & 0xfc) * 10 / 4);
+	printf("Minimum RAS# Pulse Width (tRAS)\t\t\t %d (ns*10)\n", ((record[30] & 0xfc) + (record[30] & 0x3)) * 10);
+	printf("Write Recovery Time (tWR)\t\t\t %d (ns*10)\n", record[36] * 10/ 4);
+	printf("Minimum Write to Read CMD Delay (tWTR)\t\t %d (ns*10)\n", record[37] * 10 / 4);
+	printf("Minimum Read to Pre-charge CMD Delay (tRTP)\t %d (ns*10)\n", record[38] * 10/ 4);
+	printf("Minimum Active to Auto-refresh Delay (tRC)\t %d (ns*10)\n", record[41] * 10);
+	printf("Minimum Recovery Delay (tRFC)\t\t\t %d (ns*10)\n", record[42] * 10);
+	printf("Maximum DQS to DQ Skew (tDQSQ)\t\t\t %d (ns*100)\n", record[44]);
+	printf("Maximum Read Data Hold Skew (tQHS)\t\t %d (ns*100)\n", record[45]);
+
+	printf("\n---=== Manufacturing Information ===---\n");
+
+	printf("Manufacturer JEDEC ID\t\t\t\t");
+	for (i = 64; i < 72; i++) {
+		printf(" %02x", record[i]);
+	}
+	printf("\n");
+	if (record[72]) {
+		printf("Manufacturing Location Code\t\t\t 0x%02x\n", record[72]);
+	}
+	printf("Part Number\t\t\t\t\t ");
+	for (i = 73; i < 91; i++) {
+		if (record[i] >= 32 && record[i] < 127) {
+			printf("%c", record[i]);
+		} else {
+			printf("%d", record[i]);
+		}
+	}
+	printf("\n");
+	printf("Manufacturing Date\t\t\t\t 20%d-W%d\n", record[93], record[94]);
+	printf("Assembly Serial Number\t\t\t\t 0x");
+	for (i = 95; i < 99; i++) {
+		printf("%02X", record[i]);
+	}
+	printf("\n\n");
+
+	return 0;
+}
+
+BAREBOX_CMD_START(decode)
+        .cmd            = do_decode,
+BAREBOX_CMD_END
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [RFC] add decode command (SPD EEPROM data decoder)

[Sascha Hauer]

Hi Alexander,

On Fri, Jun 19, 2015 at 06:46:02PM +0300, Alexander Smirnov wrote:
> decode-dimms perl script is used as prototype
> (see https://github.com/groeck/i2c-tools/blob/master/eeprom/decode-dimms).
> 
> Here is a sample decode output:
> 
> barebox@barebox sandbox:/ decode env/crucial_pc2-6400_ddr2
> Decoding EEPROM: env/crucial_pc2-6400_ddr2
> 
> ---=== SPD EEPROM Information ===---
> EEPROM Checksum of bytes 0-62			 OK (0xCA)
> Total number of bytes in EEPROM			 256
> Fundamental Memory type				 DDR2 SDRAM
> SPD Revision					 1.3
> 
> ---=== Memory Characteristics ===---
> Maximum module speed				 800 MHz (PC2-6400)
> Size						 1024 MB
> Banks x Rows x Columns x Bits			 8 x 14 x 10 x 64
> Ranks						 1
> SDRAM Device Width				 8 bits
> Module Height					 30.0 mm
> Module Type					 SO-DIMM (67.6 mm)
> DRAM Package					 Planar
> Voltage Interface Level				 SSTL 1.8V
> Module Configuration Type 			 No Parity
> Refresh Rate					 Reduced (7.8 us) - Self Refresh
> Supported Burst Lengths				 4, 8
> Supported CAS Latencies (tCL)			 6T
> tCL-tRCD-tRP-tRAS				 6-6-6-18 as DDR2-800
> Minimum Cycle Time				 250 (ns*100) at CAS 6
> Maximum Access Time				 4 (ns*10) at CAS 6
> Maximum Cycle Time (tCK max)			 8 ns
> 
> ---=== Timing Parameters ===---
> Address/Command Setup Time Before Clock (tIS)	 17 (ns*100)

Better print these in ns directly?

> +static int do_decode(int argc, char *argv[])
> +{
> +	int highestCAS = 0;
> +	int cas[256];
> +	int i, i_i, k;
> +	int ddrclk, tbits, pcclk;
> +	int trcd, trp, tras;
> +	int ctime;
> +	int fp;
> +	uint8_t record[256];
> +	uint8_t parity;
> +	char *ref;
> +
> +	if (argc != 2) {
> +		printf("Отсутствует или указано больше 1 аргумента\n");

I think most readers can't read this language ;)

> +		return 2;
> +	}
> +
> +	fp = open(argv[1], O_RDONLY);

better 'fd'? It's a file descriptor, not a file pointer.

> +
> +	if (fp == 0) {
> +		perror("Ошибка при работе с файлом");
> +		return 3;
> +	}
> +
> +	read(fp, &record[0], 256);
> +	close(fp);

You should separate the command code from the dispatching/printing code.
let the dispatching/printing code take a void *buf and put it into
common/. This way we can call this not only from the command but also
from C code which makes this more useful.

> +
> +//	dump(&record[0], 256);
> +
> +	printf("Decoding EEPROM: %s\n\n", argv[1]);
> +
> +	printf("---=== SPD EEPROM Information ===---\n");
> +	printf("EEPROM Checksum of bytes 0-62\t\t\t OK (0x%0X)\n", record[63]);
> +	printf("# of bytes written to SDRAM EEPROM\t\t %d\n", record[0]);
> +	printf("Total number of bytes in EEPROM\t\t\t %d\n", 1 << record[1]);
> +
> +	if (record[2] < 11) {
> +		printf("Fundamental Memory type\t\t\t\t %s\n", type_list[record[2]]);
> +	} else {
> +		printf("Warning: unknown memory type (%02x)\n", record[2]);
> +	}

Please skip the braces when they are not needed.

Generally we already have include/ddr_spd.h. If you put this struct over
the buffer then the dispatching should be more straight forward.
Wouldn't that be possible?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [RFC] add decode command (SPD EEPROM data decoder)

[Smirnov Alexander]

Hi Sascha!

22.06.2015, 08:43, "Sascha Hauer" <s.hauer@pengutronix.de>:
>  Hi Alexander,
>
>  On Fri, Jun 19, 2015 at 06:46:02PM +0300, Alexander Smirnov wrote:
>>   decode-dimms perl script is used as prototype
>>   (see https://github.com/groeck/i2c-tools/blob/master/eeprom/decode-dimms).
>>
>>   Here is a sample decode output:
>>
>>   barebox@barebox sandbox:/ decode env/crucial_pc2-6400_ddr2
>>   Decoding EEPROM: env/crucial_pc2-6400_ddr2
>>
>>   ---=== SPD EEPROM Information ===---
>>   EEPROM Checksum of bytes 0-62 OK (0xCA)
>>   Total number of bytes in EEPROM 256
>>   Fundamental Memory type DDR2 SDRAM
>>   SPD Revision 1.3
>>
>>   ---=== Memory Characteristics ===---
>>   Maximum module speed 800 MHz (PC2-6400)
>>   Size 1024 MB
>>   Banks x Rows x Columns x Bits 8 x 14 x 10 x 64
>>   Ranks 1
>>   SDRAM Device Width 8 bits
>>   Module Height 30.0 mm
>>   Module Type SO-DIMM (67.6 mm)
>>   DRAM Package Planar
>>   Voltage Interface Level SSTL 1.8V
>>   Module Configuration Type No Parity
>>   Refresh Rate Reduced (7.8 us) - Self Refresh
>>   Supported Burst Lengths 4, 8
>>   Supported CAS Latencies (tCL) 6T
>>   tCL-tRCD-tRP-tRAS 6-6-6-18 as DDR2-800
>>   Minimum Cycle Time 250 (ns*100) at CAS 6
>>   Maximum Access Time 4 (ns*10) at CAS 6
>>   Maximum Cycle Time (tCK max) 8 ns
>>
>>   ---=== Timing Parameters ===---
>>   Address/Command Setup Time Before Clock (tIS) 17 (ns*100)
>
>  Better print these in ns directly?
>
>>   +static int do_decode(int argc, char *argv[])
>>   +{
>>   + int highestCAS = 0;
>>   + int cas[256];
>>   + int i, i_i, k;
>>   + int ddrclk, tbits, pcclk;
>>   + int trcd, trp, tras;
>>   + int ctime;
>>   + int fp;
>>   + uint8_t record[256];
>>   + uint8_t parity;
>>   + char *ref;
>>   +
>>   + if (argc != 2) {
>>   + printf("Отсутствует или указано больше 1 аргумента\n");
>
>  I think most readers can't read this language ;)
>
>>   + return 2;
>>   + }
>>   +
>>   + fp = open(argv[1], O_RDONLY);
>
>  better 'fd'? It's a file descriptor, not a file pointer.
>
>>   +
>>   + if (fp == 0) {
>>   + perror("Ошибка при работе с файлом");
>>   + return 3;
>>   + }
>>   +
>>   + read(fp, &record[0], 256);
>>   + close(fp);
>
>  You should separate the command code from the dispatching/printing code.
>  let the dispatching/printing code take a void *buf and put it into
>  common/. This way we can call this not only from the command but also
>  from C code which makes this more useful.
>
>>   +
>>   +// dump(&record[0], 256);
>>   +
>>   + printf("Decoding EEPROM: %s\n\n", argv[1]);
>>   +
>>   + printf("---=== SPD EEPROM Information ===---\n");
>>   + printf("EEPROM Checksum of bytes 0-62\t\t\t OK (0x%0X)\n", record[63]);
>>   + printf("# of bytes written to SDRAM EEPROM\t\t %d\n", record[0]);
>>   + printf("Total number of bytes in EEPROM\t\t\t %d\n", 1 << record[1]);
>>   +
>>   + if (record[2] < 11) {
>>   + printf("Fundamental Memory type\t\t\t\t %s\n", type_list[record[2]]);
>>   + } else {
>>   + printf("Warning: unknown memory type (%02x)\n", record[2]);
>>   + }
>
>  Please skip the braces when they are not needed.
>
>  Generally we already have include/ddr_spd.h. If you put this struct over
>  the buffer then the dispatching should be more straight forward.
>  Wouldn't that be possible?

Thanks for your review!
I'll try to rework my patch and resubmit it in a few days.

-- 
С уважением,
 Smirnov Alexander

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox