mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] ARM: socfpga: socrates: add qspi partitions
Date: Thu, 16 Jul 2015 08:47:00 +0200	[thread overview]
Message-ID: <20150716064700.GC20836@pengutronix.de> (raw)
In-Reply-To: <20150716060723.GX18700@pengutronix.de>

On Thu, Jul 16, 2015 at 08:07:23AM +0200, Sascha Hauer wrote:
> On Tue, Jul 14, 2015 at 06:16:35PM +0200, Steffen Trumtrar wrote:
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/dts/socfpga_cyclone5_socrates.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/arch/arm/dts/socfpga_cyclone5_socrates.dts b/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > index 125ad1b8502d..ccb940584b5b 100644
> > --- a/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > +++ b/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > @@ -80,5 +80,20 @@
> >  		cdns,tsd2d-ns = <50>;
> >  		cdns,tchsh-ns = <4>;
> >  		cdns,tslch-ns = <4>;
> > +
> > +		partition@0 {
> > +			label = "prebootloader0";
> > +			reg = <0x00000 0x10000>;
> > +		};
> 
> Why prebootloader0? There's only one or not?
> 

There can be up to four and the space for the other
three is left free here. I thought prebootloader1-3 might
be added later.

> > +
> > +		partition@1 {
> > +			label = "barebox0";
> > +			reg = <0x40000 0x80000>;
> > +		};
> 
> Same here.
> 

No good argument. So, I will have to change this :-(

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-07-16  6:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 16:16 Steffen Trumtrar
2015-07-14 16:16 ` [PATCH 2/5] ARM: socfpga: socrates: set alias for ethernet0 Steffen Trumtrar
2015-07-14 16:16 ` [PATCH 3/5] ARM: socfpga: add bbu handler for spi nor Steffen Trumtrar
2015-07-16  6:12   ` Sascha Hauer
2015-07-16  7:01     ` Sascha Hauer
2015-07-16  8:09       ` Steffen Trumtrar
2015-07-14 16:16 ` [PATCH 4/5] ARM: socfpga: socrates: register spi bbu handler Steffen Trumtrar
2015-07-14 16:16 ` [PATCH 5/5] ARM: socfpga: defconfig: add bootstrap_devfs Steffen Trumtrar
2015-07-16  6:07 ` [PATCH 1/5] ARM: socfpga: socrates: add qspi partitions Sascha Hauer
2015-07-16  6:47   ` Steffen Trumtrar [this message]
2015-07-16  6:59     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716064700.GC20836@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox