mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC v2 00/16] barebox picotcp integration (2015.07.19)
Date: Mon, 20 Jul 2015 12:45:24 +0200	[thread overview]
Message-ID: <20150720104524.GC18700@pengutronix.de> (raw)
In-Reply-To: <20150720130649.24ddbd5dd3f7e3cd7de9b3a0@gmail.com>

On Mon, Jul 20, 2015 at 01:06:49PM +0300, Antony Pavlov wrote:
> On Mon, 20 Jul 2015 09:10:13 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > Hi Antony,
> > 
> > On Sun, Jul 19, 2015 at 11:07:07PM +0300, Antony Pavlov wrote:
> > > I have just published latest picotcp-enabled barebox.
> > > Please see my 20150719.picotcp branch in my github barebox repo
> > > (https://github.com/frantony/barebox/tree/20150719.picotcp).
> > > 
> > > This version is based on the latest barebox-next and picotcp v1.5.0
> > > (there is also picotcp v1.5.1, but is has no interested
> > > for barebox changes since v1.5.0).
> > > 
> > > 
> > > Changes since 2015.07.15 (see http://lists.infradead.org/pipermail/barebox/2015-June/024174.html):
> > > 
> > >     * net: UDP API changed to satisfy the picotcp integration needs;
> > >     * nfs, tftp and dns subsystems have no picotcp-related stuff anymore.
> > >     * netconsole works on top of picotcp with no additional changes.
> > > 
> > > 
> > > Here are some notes:
> > > 
> > >   1. just now tftp/nfs file transfer on top of picotcp is slower than
> > >      the same transfer on top of legacy network stack;
> > > 
> > >   2. there is no $<current network interface> anymore,
> > >      so dhcp, tftp and ifup commands don't work on top of picotcp.
> > >      The ifconfig command is used for network interfaces setup.
> > > 
> > >      N.B. There is an old patch for dhcp support on top of picotcp
> > >         https://github.com/frantony/barebox/commit/94021b6d7bb933cd50b7ea9e2c55725b5c404205
> > > 
> > >   3. The picoping command is used insted of traditional ping command.
> > 
> > First of all I applied patches 1-4 to next.
> 
> Sascha!
> 
> Please comment patches 5-7!
> 
> Probably these patches will be changed in the next picotcp integration patchseries version,
> but your comment on them could be very beneficial.

From looking at them they are ok. I haven't found the place where you
allocate packets now, but please make sure they are aligned for dma
accesses, i.e. use net_alloc_packet(). Otherwise this happens:

eth0: Transmit data not aligned: c0416acc!

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-07-20 10:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19 20:07 Antony Pavlov
2015-07-19 20:07 ` [RFC v2 01/16] net_udp_bind(): use uint16_t type for source port Antony Pavlov
2015-07-19 20:07 ` [RFC v2 02/16] fs/tftp.c: drop unused server_port variable Antony Pavlov
2015-07-19 20:07 ` [RFC v2 03/16] fs/nfs.c: use uint16_t for port numbers Antony Pavlov
2015-07-19 20:07 ` [RFC v2 04/16] fs/nfs.c: use SUNRPC_PORT remote port by default Antony Pavlov
2015-07-19 20:07 ` [RFC v2 05/16] net: change UDP handler function API Antony Pavlov
2015-07-19 20:07 ` [RFC v2 06/16] net: change net_udp_send() API Antony Pavlov
2015-07-19 20:07 ` [RFC v2 07/16] net: introduce setudppeerport() Antony Pavlov
2015-07-19 20:07 ` [RFC v2 08/16] net: import picotcp from github Antony Pavlov
2015-07-19 20:07 ` [RFC v2 09/16] picotcp: add barebox target support Antony Pavlov
2015-07-19 20:07 ` [RFC v2 10/16] picotcp: switch to Kbuild Antony Pavlov
2015-07-19 20:07 ` [RFC v2 11/16] net: add initial picotcp support Antony Pavlov
2015-07-19 20:07 ` [RFC v2 12/16] net: picotcp: add test_picotcp command Antony Pavlov
2015-07-19 20:07 ` [RFC v2 13/16] net: picotcp: add ifconfig command Antony Pavlov
2015-07-19 20:07 ` [RFC v2 14/16] net: picotcp: add ping command Antony Pavlov
2015-07-19 20:07 ` [RFC v2 15/16] net: picotcp: add route command Antony Pavlov
2015-07-19 20:07 ` [RFC v2 16/16] sandbox_defconfig: switch to picotcp Antony Pavlov
2015-07-20  7:10 ` [RFC v2 00/16] barebox picotcp integration (2015.07.19) Sascha Hauer
2015-07-20  9:50   ` Antony Pavlov
2015-07-20 10:06   ` Antony Pavlov
2015-07-20 10:45     ` Sascha Hauer [this message]
2015-07-20 12:16       ` Antony Pavlov
2015-07-24  4:58       ` Antony Pavlov
2015-07-24  7:19         ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150720104524.GC18700@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox