From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZIXGj-0008Gn-Iq for barebox@lists.infradead.org; Fri, 24 Jul 2015 07:19:46 +0000 Date: Fri, 24 Jul 2015 09:19:23 +0200 From: Sascha Hauer Message-ID: <20150724071923.GL18700@pengutronix.de> References: <1437336443-8076-1-git-send-email-antonynpavlov@gmail.com> <20150720071013.GX18700@pengutronix.de> <20150720130649.24ddbd5dd3f7e3cd7de9b3a0@gmail.com> <20150720104524.GC18700@pengutronix.de> <20150724075856.2b8a3e2c845ccbf32032cdb6@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150724075856.2b8a3e2c845ccbf32032cdb6@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC v2 00/16] barebox picotcp integration (2015.07.19) To: Antony Pavlov Cc: barebox@lists.infradead.org On Fri, Jul 24, 2015 at 07:58:56AM +0300, Antony Pavlov wrote: > On Mon, 20 Jul 2015 12:45:24 +0200 > Sascha Hauer wrote: > > > On Mon, Jul 20, 2015 at 01:06:49PM +0300, Antony Pavlov wrote: > > > On Mon, 20 Jul 2015 09:10:13 +0200 > > > Sascha Hauer wrote: > > > > > > > Hi Antony, > > > > > > > > On Sun, Jul 19, 2015 at 11:07:07PM +0300, Antony Pavlov wrote: > > > > > I have just published latest picotcp-enabled barebox. > > > > > Please see my 20150719.picotcp branch in my github barebox repo > > > > > (https://github.com/frantony/barebox/tree/20150719.picotcp). > > > > > > > > > > This version is based on the latest barebox-next and picotcp v1.5.0 > > > > > (there is also picotcp v1.5.1, but is has no interested > > > > > for barebox changes since v1.5.0). > > > > > > > > > > > > > > > Changes since 2015.07.15 (see http://lists.infradead.org/pipermail/barebox/2015-June/024174.html): > > > > > > > > > > * net: UDP API changed to satisfy the picotcp integration needs; > > > > > * nfs, tftp and dns subsystems have no picotcp-related stuff anymore. > > > > > * netconsole works on top of picotcp with no additional changes. > > > > > > > > > > > > > > > Here are some notes: > > > > > > > > > > 1. just now tftp/nfs file transfer on top of picotcp is slower than > > > > > the same transfer on top of legacy network stack; > > > > > > > > > > 2. there is no $ anymore, > > > > > so dhcp, tftp and ifup commands don't work on top of picotcp. > > > > > The ifconfig command is used for network interfaces setup. > > > > > > > > > > N.B. There is an old patch for dhcp support on top of picotcp > > > > > https://github.com/frantony/barebox/commit/94021b6d7bb933cd50b7ea9e2c55725b5c404205 > > > > > > > > > > 3. The picoping command is used insted of traditional ping command. > > > > > > > > First of all I applied patches 1-4 to next. > > > > > > Sascha! > > > > > > Please comment patches 5-7! > > > > > > Probably these patches will be changed in the next picotcp integration patchseries version, > > > but your comment on them could be very beneficial. > > > > From looking at them they are ok. I haven't found the place where you > > allocate packets now, but please make sure they are aligned for dma > > accesses, i.e. use net_alloc_packet(). Otherwise this happens: > > > > eth0: Transmit data not aligned: c0416acc! > > > > Could you try this patch, please? With this the packets are now sufficiently aligned. When I replace edev->send with eth_send in pico_adapter_send I get a step further. Packets are still sent with the wrong mac address. It uses 00:00:00:0a:0b:0c which is probably some dummy value you introduced somehwere, but the ethernet device is never configured with that value. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox