From: Sascha Hauer <s.hauer@pengutronix.de>
To: Stefan Christ <s.christ@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: [phyFLEX,phyCARD]-i.MX6: rename define in flash-headers
Date: Wed, 29 Jul 2015 07:59:24 +0200 [thread overview]
Message-ID: <20150729055924.GF18700@pengutronix.de> (raw)
In-Reply-To: <1437999653-15630-1-git-send-email-s.christ@phytec.de>
On Mon, Jul 27, 2015 at 02:20:53PM +0200, Stefan Christ wrote:
> The files flash-header-*.imxfg contains two defines which are use in
> include files flash-header-phytec-*.h. The first define is SETUP_MDCFG0.
> In the second define name some RAM size value were used, e.g.
> SETUP_S_DL_512MB_1GB or SETUP_1GIB_2GIB_4GIB.
>
> It's better to name also the second define after the register names,
> here MMDC1_MDCTL and MMDC1_MDASP, because these values changes for every
> RAM configurations and it's consistent with the first define.
>
> Signed-off-by: Stefan Christ <s.christ@phytec.de>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-07-29 5:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 12:20 Stefan Christ
2015-07-29 5:59 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729055924.GF18700@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.christ@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox