From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZS4I4-0005sl-6a for barebox@lists.infradead.org; Wed, 19 Aug 2015 14:24:33 +0000 Date: Wed, 19 Aug 2015 16:24:10 +0200 From: Sascha Hauer Message-ID: <20150819142410.GH18700@pengutronix.de> References: <1439584319-4068-1-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1439584319-4068-1-git-send-email-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] lib: libfile: Do not ignore errors in close() To: Andrey Smirnov Cc: barebox@lists.infradead.org On Fri, Aug 14, 2015 at 01:31:58PM -0700, Andrey Smirnov wrote: > Some character devices may perform meaningful operations in their > implementation of close() -- a good example would be socfpga.c which > checks if the FPGA was programmed succesfully in it's close() method > -- so ignoring return value of this call may cause false positives in > checking exit status for success. > > Signed-off-by: Andrey Smirnov > --- > lib/libfile.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox