From: Antony Pavlov <antonynpavlov@gmail.com>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] RFC: include/usb/ch9.h: pad usb_endpoint_descriptor with 1 byte
Date: Fri, 21 Aug 2015 12:04:48 +0300 [thread overview]
Message-ID: <20150821120448.b9303fc43382e0f871bd7fd1@gmail.com> (raw)
In-Reply-To: <1440084138-3116-1-git-send-email-pmamonov@gmail.com>
On Thu, 20 Aug 2015 18:22:18 +0300
Peter Mamonov <pmamonov@gmail.com> wrote:
> This patch fixes "Ooops, address error on load or ifetch!",
> caused by "usb" command on MIPS architecture.
>
> To reproduce the problem follow the following steps:
>
> 1. Build barebox for MIPS target with -O0 optimization flag:
>
> diff --git a/Makefile b/Makefile
> index 5a7fd5f..da9a8be 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -301,7 +301,7 @@ CPPFLAGS := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffre
>
> CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> -Werror-implicit-function-declaration \
> - -fno-strict-aliasing -fno-common -Os -pipe
> + -fno-strict-aliasing -fno-common -O0 -pipe
> AFLAGS := -D__ASSEMBLY__
>
> LDFLAGS_barebox := -Map barebox.map
It's better to add some indentation here because the patches with patches in commit message make problem for 'git am'.
Also it's better to change the subject of the message. Use "[RFC]" instead of "[PATCH] RFC:".
Please see --subject-prefix git-format-patch option.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-08-21 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 15:22 Peter Mamonov
2015-08-21 9:04 ` Antony Pavlov [this message]
2015-08-24 8:49 ` Sascha Hauer
2015-08-24 14:35 ` Antony Pavlov
2015-08-24 15:10 ` Lucas Stach
2015-08-24 22:42 ` Antony Pavlov
2015-08-26 12:45 ` Peter Mamonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821120448.b9303fc43382e0f871bd7fd1@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox