From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: ehci-hcd: initialize ehci->qh_list[] with zeros
Date: Wed, 26 Aug 2015 14:12:51 +0200 [thread overview]
Message-ID: <20150826121251.GT18700@pengutronix.de> (raw)
In-Reply-To: <1440498836-8650-1-git-send-email-pmamonov@gmail.com>
On Tue, Aug 25, 2015 at 01:33:56PM +0300, Peter Mamonov wrote:
> Without this initialization ehci->qh_list[0].qh_endpt2 is left uninitialized,
> which causes problems with some EHCI host controllers.
>
> Das u-boot uses the same strategy:
>
> static int ehci_common_init(struct ehci_ctrl *ctrl, uint tweaks)
> {
> ...
> qh_list = &ctrl->qh_list;
>
> /* Set head of reclaim list */
> memset(qh_list, 0, sizeof(*qh_list));
> qh_list->qh_link = cpu_to_hc32((unsigned long)qh_list | QH_LINK_TYPE_QH);
> qh_list->qh_endpt1 = cpu_to_hc32(QH_ENDPT1_H(1) |
> QH_ENDPT1_EPS(USB_SPEED_HIGH));
> qh_list->qh_overlay.qt_next = cpu_to_hc32(QT_NEXT_TERMINATE);
> qh_list->qh_overlay.qt_altnext = cpu_to_hc32(QT_NEXT_TERMINATE);
> qh_list->qh_overlay.qt_token =
> cpu_to_hc32(QT_TOKEN_STATUS(QT_TOKEN_STATUS_HALTED));
> ...
> }
>
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-08-26 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 10:33 Peter Mamonov
2015-08-26 12:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826121251.GT18700@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox