From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] usb: ehci-hcd: add OF bindings
Date: Thu, 27 Aug 2015 21:41:07 +0200 [thread overview]
Message-ID: <20150827194107.GX18700@pengutronix.de> (raw)
In-Reply-To: <1440694111-1088-1-git-send-email-pmamonov@gmail.com>
On Thu, Aug 27, 2015 at 07:48:31PM +0300, Peter Mamonov wrote:
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
> drivers/usb/host/ehci-hcd.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 1146b71..ef555eb 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -940,12 +940,16 @@ static int ehci_probe(struct device_d *dev)
> {
> struct ehci_data data = {};
> struct ehci_platform_data *pdata = dev->platform_data;
> + struct device_node *dn = dev->device_node;
> + uint32_t flags;
>
> /* default to EHCI_HAS_TT to not change behaviour of boards
> * without platform_data
> */
> if (pdata)
> data.flags = pdata->flags;
> + else if (dn && of_property_read_u32(dn, "flags", &flags) == 0)
> + data.flags = flags;
Shouldn't you check the has-transaction-translator boolean property
instead? That's what documented in dts/Bindings/usb/usb-ehci.txt
Otherwise looks good.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-08-27 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 16:48 Peter Mamonov
2015-08-27 19:41 ` Sascha Hauer [this message]
2015-08-28 11:06 Peter Mamonov
2015-09-04 6:06 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827194107.GX18700@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox