From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, Peter Mamonov <pmamonov@gmail.com>
Subject: Re: [PATCH] ata: intf_platform_ide: add OF bindings
Date: Thu, 3 Sep 2015 20:16:36 +0200 [thread overview]
Message-ID: <20150903181636.GL18700@pengutronix.de> (raw)
In-Reply-To: <20150903193155.1127b6d5fa5948cc70ec4a16@gmail.com>
On Thu, Sep 03, 2015 at 07:31:55PM +0300, Antony Pavlov wrote:
> On Thu, 03 Sep 2015 17:46:32 +0200
> Lucas Stach <l.stach@pengutronix.de> wrote:
>
> > Hi Peter.
> >
> > Sorry, but this patch is wrong. You can't just make up completely ad-hoc
> > DT bindings. You are pushing platformdata 1:1 into the DT, which is not
> > how the conversion to DT should be done.
> >
> > There is also no pre-existing binding for "ata-generic" in the Linux
> > kernel which would define any of those properties.
>
> Hmmm. in linux-4.2/drivers/ata/pata_of_platform.c I see "ata-generic"
> with "reg-shift" and "pio-mode" properties.
It seems this binding comes from the good old days when writing binding
doc was an optional task ;)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-09-03 18:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 13:38 Peter Mamonov
2015-09-03 14:24 ` Antony Pavlov
2015-09-03 15:33 ` Peter Mamonov
2015-09-03 16:04 ` Peter Mamonov
2015-09-03 18:13 ` Sascha Hauer
2015-09-07 15:44 ` [PATCHv2] " Peter Mamonov
2015-09-07 15:53 ` Lucas Stach
2015-09-07 16:43 ` [PATCHv3] " Peter Mamonov
2015-09-09 6:54 ` Sascha Hauer
2015-09-03 15:46 ` [PATCH] " Lucas Stach
2015-09-03 16:31 ` Antony Pavlov
2015-09-03 18:16 ` Sascha Hauer [this message]
2015-09-04 10:15 ` Peter Mamonov
2015-09-04 9:40 ` Peter Mamonov
2015-09-04 10:23 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903181636.GL18700@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox