mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] console: use int rather than uint in printf() and friends
@ 2015-09-04 11:27 Masahiro Yamada
  2015-09-07  5:24 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2015-09-04 11:27 UTC (permalink / raw)
  To: barebox

These functions and vsprintf() return int type.
No reason to use uint type.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 common/console_common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/console_common.c b/common/console_common.c
index fcf89e8..a9bbce9 100644
--- a/common/console_common.c
+++ b/common/console_common.c
@@ -105,7 +105,7 @@ nolog:
 int pr_print(int level, const char *fmt, ...)
 {
 	va_list args;
-	uint i;
+	int i;
 	char printbuffer[CFG_PBSIZE];
 
 	if (!IS_ENABLED(CONFIG_LOGBUF) && level > barebox_loglevel)
@@ -191,7 +191,7 @@ void log_print(unsigned flags)
 int printf(const char *fmt, ...)
 {
 	va_list args;
-	uint i;
+	int i;
 	char printbuffer[CFG_PBSIZE];
 
 	va_start(args, fmt);
@@ -212,7 +212,7 @@ EXPORT_SYMBOL(printf);
 
 int vprintf(const char *fmt, va_list args)
 {
-	uint i;
+	int i;
 	char printbuffer[CFG_PBSIZE];
 
 	/*
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] console: use int rather than uint in printf() and friends
  2015-09-04 11:27 [PATCH] console: use int rather than uint in printf() and friends Masahiro Yamada
@ 2015-09-07  5:24 ` Sascha Hauer
  2015-09-24  9:39   ` Masahiro Yamada
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2015-09-07  5:24 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: barebox

On Fri, Sep 04, 2015 at 08:27:11PM +0900, Masahiro Yamada wrote:
> These functions and vsprintf() return int type.
> No reason to use uint type.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] console: use int rather than uint in printf() and friends
  2015-09-07  5:24 ` Sascha Hauer
@ 2015-09-24  9:39   ` Masahiro Yamada
  2015-09-24 17:33     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2015-09-24  9:39 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

Hi Sascha,

2015-09-07 14:24 GMT+09:00 Sascha Hauer <s.hauer@pengutronix.de>:
> On Fri, Sep 04, 2015 at 08:27:11PM +0900, Masahiro Yamada wrote:
>> These functions and vsprintf() return int type.
>> No reason to use uint type.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>
> Applied, thanks
>
> Sascha
>

Looks like it was applied to  for-next/mci and for-next/misc.

Perhaps, one of them is enough?



-- 
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] console: use int rather than uint in printf() and friends
  2015-09-24  9:39   ` Masahiro Yamada
@ 2015-09-24 17:33     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2015-09-24 17:33 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: barebox

Hi,

On Thu, Sep 24, 2015 at 06:39:01PM +0900, Masahiro Yamada wrote:
> Hi Sascha,
> 
> 2015-09-07 14:24 GMT+09:00 Sascha Hauer <s.hauer@pengutronix.de>:
> > On Fri, Sep 04, 2015 at 08:27:11PM +0900, Masahiro Yamada wrote:
> >> These functions and vsprintf() return int type.
> >> No reason to use uint type.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> ---
> >
> > Applied, thanks
> >
> > Sascha
> >
> 
> Looks like it was applied to  for-next/mci and for-next/misc.
> 
> Perhaps, one of them is enough?

Oops, indeed. I removed it from for-next/mci.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-24 17:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-04 11:27 [PATCH] console: use int rather than uint in printf() and friends Masahiro Yamada
2015-09-07  5:24 ` Sascha Hauer
2015-09-24  9:39   ` Masahiro Yamada
2015-09-24 17:33     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox