mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 3/4] drivers: mci: Add mci_get_device_by_name function
Date: Mon, 7 Sep 2015 07:47:29 +0200	[thread overview]
Message-ID: <20150907054729.GX18700@pengutronix.de> (raw)
In-Reply-To: <1441175333-26759-3-git-send-email-d.schultz@phytec.de>

On Wed, Sep 02, 2015 at 08:28:52AM +0200, Daniel Schultz wrote:
> Get a 'struct mci' by search after the device name.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
> 
> Changes:
> 	v3:
> 	New with patch v3
> 
>  drivers/mci/mci-core.c | 16 ++++++++++++++++
>  include/mci.h          |  8 ++++++++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index c22f932..d6865d1 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -53,6 +53,8 @@
>  		__res & __mask;						\
>  	})
>  
> +LIST_HEAD(mci_list);
> +
>  /**
>   * @file
>   * @brief Memory Card framework
> @@ -1753,6 +1755,8 @@ int mci_register(struct mci_host *host)
>  		mci->dev.id = DEVICE_ID_DYNAMIC;
>  	}
>  
> +	list_add_tail(&mci->list, &mci_list);
> +

mci_register() may fail later in which case you end up with an undefined
entry in the mci_list. This should be done near the end of
mci_register() when it can't fail anymore.

>  	mci->dev.platform_data = host;
>  	mci->dev.parent = host->hw_dev;
>  	mci->host = host;
> @@ -1844,3 +1848,15 @@ void mci_of_parse(struct mci_host *host)
>  
>  	host->non_removable = of_property_read_bool(np, "non-removable");
>  }
> +
> +struct mci *mci_get_device_by_name(const char *name)
> +{
> +	struct mci *dev;
> +
> +	for_each_mci_device(dev) {
> +		if (!strcmp(dev->cdevname, name))
> +			return dev;
> +	}

dev->cdevname is initialized only in mci_card_probe() and only when
actually a card is detected. This causes a NULL pointer exception for
example when a there's no card in a slot. This has to be checked here.

It's a bit confusing when a variable named 'dev' not of type struct
device_d. Please rather use more specific names, like 'mci' in this
case.

I applied a fixed version to the -next branch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-09-07  5:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02  6:28 [PATCH v3 1/4] drivers: mci: Make two functions public Daniel Schultz
2015-09-02  6:28 ` [PATCH v3 2/4] include: mci: Add new ext. CSD field defines Daniel Schultz
2015-09-02  6:28 ` [PATCH v3 3/4] drivers: mci: Add mci_get_device_by_name function Daniel Schultz
2015-09-07  5:47   ` Sascha Hauer [this message]
2015-09-02  6:28 ` [PATCH v3 4/4] commands: Add MMC ext. CSD register tool Daniel Schultz
2015-09-07  7:00   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150907054729.GX18700@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=d.schultz@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox