From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZaPj6-0002l7-IQ for barebox@lists.infradead.org; Fri, 11 Sep 2015 14:55:00 +0000 Received: by lamp12 with SMTP id p12so48775908lam.0 for ; Fri, 11 Sep 2015 07:54:34 -0700 (PDT) Date: Fri, 11 Sep 2015 17:56:53 +0300 From: Peter Mamonov Message-ID: <20150911175653.69871b3b@berta> In-Reply-To: <20150910172111.GR18700@pengutronix.de> References: <1441816612-5471-1-git-send-email-pmamonov@gmail.com> <20150910073815.GQ18700@pengutronix.de> <20150910185133.7a11e8f0@berta> <20150910172111.GR18700@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC] WIP: add usb keyboard driver To: Sascha Hauer Cc: barebox@lists.infradead.org On Thu, 10 Sep 2015 19:21:11 +0200 Sascha Hauer wrote: > On Thu, Sep 10, 2015 at 06:51:33PM +0300, Peter Mamonov wrote: > > On Thu, 10 Sep 2015 09:38:15 +0200 > > Sascha Hauer wrote: > > > > > Excellent! This makes the framebuffer console support complete :) > > > > I'm sorry to dissapoint you, but this implementation of the usb > > keyboard driver seems to be wrong. The driver employs the get_report > > request to poll the keyboard state via the control endpoint, however > > the "Device Class Definition for Human Interface Devices (HID)" > > states the following: > > "This request is not intended to be used for polling the device > > state on a regular basis. [...] The Interrupt In pipe should be > > used for recurring Input reports." > > > > I guess this is the source of the problems with some keyboards: 2 > > of 4 keyboards I've tested changed their state only on key down, > > but not on key up. > > Yes, same here. The first keyboard I tested ended up with this > behaviour, the second worked. > > > > > So, according the standard, we need to poll a keyboard via interrupt > > endpoint. However, current implementation of EHCI driver doesn't > > support interrupt transactions: submit_int_msg() in ehci-hcd.c is a > > stub. I'll try to implement it. > > U-Boot has an implementation for it, should be possible to adopt the > corresponding code. I've ported missing functionality from the u-boot and switched to polling via interrupt endpoint. After that all keyboards work fine. Will clean up the code and post the patches. Peter > > Sascha > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox