From: Antony Pavlov <antonynpavlov@gmail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, Kevin Du Huanpeng <u74147@gmail.com>
Subject: Re: [PATCH] MIPS: start.S depends on banner
Date: Wed, 16 Sep 2015 10:57:41 +0300 [thread overview]
Message-ID: <20150916105741.897dffacd4102c19cb060933@gmail.com> (raw)
In-Reply-To: <20150916105033.d6d9a93ef5344d0c12ad4334@gmail.com>
On Wed, 16 Sep 2015 10:50:33 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
> On Wed, 16 Sep 2015 14:40:48 +0800
> Kevin Du Huanpeng <u74147@gmail.com> wrote:
>
> > Signed-off-by: Kevin Du Huanpeng <u74147@gmail.com>
> > ---
> > arch/mips/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index aeb5c04..fde4c2e 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -6,6 +6,7 @@ config MIPS
> > select HAS_KALLSYMS
> > select HAVE_CONFIGURABLE_MEMORY_LAYOUT
> > select HAVE_CONFIGURABLE_TEXT_BASE
> > + select BANNER
> > default y
> >
> > config SYS_SUPPORTS_BIG_ENDIAN
> > --
> > 1.9.1
> >
>
> IMHO we can make banner use in start.S optional. E.g.:
>
> diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S
> index 7e2ae5e..f3a6a00 100644
> --- a/arch/mips/boot/start.S
> +++ b/arch/mips/boot/start.S
> @@ -22,8 +22,10 @@
> #include <asm/mipsregs.h>
> #include <asm/asm.h>
> #include <asm-generic/memory_layout.h>
> +#ifdef CONFIG_BANNER
> #include <generated/compile.h>
> #include <generated/utsrelease.h>
> +#endif
>
> /*
> * ADR macro instruction (inspired by ARM)
> @@ -52,6 +54,7 @@ _pc: addiu \rd, ra, \label - _pc # label is assumed to be
>
> EXPORT(_start)
>
> +#ifdef CONFIG_BANNER
> b __start
> nop
>
> @@ -60,6 +63,8 @@ EXPORT(_start)
> .byte 0
>
> .align 4
> +#endif /* CONFIG_BANNER */
I see just the same code in the mips_barebox_10h macro from arch/mips/include/asm/pbl_macros.h.
> +
> __start:
> /* disable watchpoints */
> mtc0 zero, CP0_WATCHLO
>
> Or even add an separate option to include utsrelease information into start.S.
>
> --
> Best regards,
> Antony Pavlov
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-09-16 7:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 6:40 Kevin Du Huanpeng
2015-09-16 7:50 ` Antony Pavlov
2015-09-16 7:57 ` Antony Pavlov [this message]
2015-09-16 8:35 ` Sascha Hauer
2015-09-16 9:06 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916105741.897dffacd4102c19cb060933@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=u74147@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox