mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] of_fix_tree: fo not fail when fixup fails
@ 2015-09-23 15:23 Sascha Hauer
  2015-09-23 22:35 ` Marc Reilly
  0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2015-09-23 15:23 UTC (permalink / raw)
  To: Barebox List

When a device tree fixup fails it is worth printing a warning, but
we should not fail booting.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/oftree.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/common/oftree.c b/common/oftree.c
index cafe46c..d408f14 100644
--- a/common/oftree.c
+++ b/common/oftree.c
@@ -189,11 +189,9 @@ int of_fix_tree(struct device_node *node)
 
 	list_for_each_entry(of_fixup, &of_fixup_list, list) {
 		ret = of_fixup->fixup(node, of_fixup->context);
-		if (ret) {
-			pr_err("Failed to fixup node in %pS: %s\n",
+		if (ret)
+			pr_warn("Failed to fixup node in %pS: %s\n",
 					of_fixup->fixup, strerror(-ret));
-			return ret;
-		}
 	}
 
 	return 0;
-- 
2.5.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of_fix_tree: fo not fail when fixup fails
  2015-09-23 15:23 [PATCH] of_fix_tree: fo not fail when fixup fails Sascha Hauer
@ 2015-09-23 22:35 ` Marc Reilly
  2015-09-24  6:01   ` Sascha Hauer
  0 siblings, 1 reply; 3+ messages in thread
From: Marc Reilly @ 2015-09-23 22:35 UTC (permalink / raw)
  To: barebox

Hi,

Should the subject be "do not fail .."  (s/fo/do) ?

Cheers,
Marc


On Wednesday, September 23, 2015 05:23:56 PM Sascha Hauer wrote:
> When a device tree fixup fails it is worth printing a warning, but
> we should not fail booting.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  common/oftree.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/common/oftree.c b/common/oftree.c
> index cafe46c..d408f14 100644
> --- a/common/oftree.c
> +++ b/common/oftree.c
> @@ -189,11 +189,9 @@ int of_fix_tree(struct device_node *node)
> 
>  	list_for_each_entry(of_fixup, &of_fixup_list, list) {
>  		ret = of_fixup->fixup(node, of_fixup->context);
> -		if (ret) {
> -			pr_err("Failed to fixup node in %pS: %s\n",
> +		if (ret)
> +			pr_warn("Failed to fixup node in %pS: %s\n",
>  					of_fixup->fixup, strerror(-ret));
> -			return ret;
> -		}
>  	}
> 
>  	return 0;


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of_fix_tree: fo not fail when fixup fails
  2015-09-23 22:35 ` Marc Reilly
@ 2015-09-24  6:01   ` Sascha Hauer
  0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2015-09-24  6:01 UTC (permalink / raw)
  To: Marc Reilly; +Cc: barebox

Hi Marc,

On Thu, Sep 24, 2015 at 08:35:54AM +1000, Marc Reilly wrote:
> Hi,
> 
> Should the subject be "do not fail .."  (s/fo/do) ?

Indeed, thanks. Fixed.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-24  6:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-23 15:23 [PATCH] of_fix_tree: fo not fail when fixup fails Sascha Hauer
2015-09-23 22:35 ` Marc Reilly
2015-09-24  6:01   ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox