From: Sascha Hauer <s.hauer@pengutronix.de>
To: Vicente Bergas <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] xload: be more flexible when searching for second stage bootloader.
Date: Tue, 29 Sep 2015 09:05:23 +0200 [thread overview]
Message-ID: <20150929070523.GP7858@pengutronix.de> (raw)
In-Reply-To: <1443362931-1881-1-git-send-email-vicencb@gmail.com>
On Sun, Sep 27, 2015 at 03:08:51PM +0100, Vicente Bergas wrote:
> A first stage bootloader can read fat and ext4 filesystems, and
> even both can be compiled-in at the same time.
> But then xload has a hardcoded fat filesystem mount option which
> renders ext4 unusable.
> This patch tries to mount it as ext4 if the fat attempt fails.
>
> Then, a typical use case of an ext4 formatted filesystem
> is it to be a standard linux filesystem, which contains
> boot-related files in /boot. So, when searching for the second stage
> bootloader, try /boot/barebox.bin after not finding it in /barebox.bin
>
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> ---
> arch/arm/mach-omap/xload.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
> index ebcbcbc..c5e29f8 100644
> --- a/arch/arm/mach-omap/xload.c
> +++ b/arch/arm/mach-omap/xload.c
> @@ -118,6 +118,8 @@ static void *omap_xload_boot_mmc(void)
> partname = asprintf("%s.0", diskdev);
>
> ret = mount(partname, "fat", "/", NULL);
> + if (ret)
> + ret = mount(partname, "ext4", "/", NULL);
It should also be possible to pass NULL as fs type in which case we
automatically detect the fs type. Could you check that?
Where does the MLO come from when you don't have a FAT on your MMC/SD
device? Don't we need FAT on the first partition to let the boot ROM
load the MLO?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-09-29 7:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 14:08 Vicente Bergas
2015-09-29 7:05 ` Sascha Hauer [this message]
2015-09-29 19:06 ` vj
2015-09-30 7:19 ` Sascha Hauer
2015-09-30 17:49 ` vj
2015-10-01 6:04 ` Sascha Hauer
2015-10-01 23:08 ` [PATCH 0/2] second version for "be more flexible when searching for second stage" Vicente Bergas
2015-10-01 23:08 ` [PATCH 1/2] detect_fs: use device instead of file Vicente Bergas
2015-10-01 23:08 ` [PATCH 2/2] xload: be more flexible when searching for second stage bootloader Vicente Bergas
2015-10-02 7:11 ` [PATCH 0/2] second version for "be more flexible when searching for second stage" Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929070523.GP7858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox