mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini-list@gnudd.com>
To: barebox@lists.infradead.org
Cc: scaglia@amelchem.com, braghiroli@amelchem.com
Subject: Re: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)
Date: Thu, 1 Oct 2015 23:59:36 +0200	[thread overview]
Message-ID: <20151001215936.GA1121@mail.gnudd.com> (raw)
In-Reply-To: <20151001214801.GA731@mail.gnudd.com>

> Subject: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)

Argh! After a lot of editing, the subject line is wrong.

   fix ROM base address (bugfix for nand ECC)

Anyways, let me add this detail.  The current code considers the
case where dev_request_mem_region() fails.

        host->pmecc_rom_base = dev_request_mem_region(dev, 3);
        if (!host->pmecc_rom_base) {
                   [...]

What it does in "[...]" is creating the tables with proper math..  I
tried to skip the request_mem_region() above and ECC works perfectly,
with the software-generated table.

So I wonder whether it makes sense to just remove the declaration of
the ROM are memory-region-3 for NAND, and just use the software-built
tables.

This wouldn't void the previous patch: the ROM address is wrong
as defined, for all CPU types that fall under "at91sam9x5" (I checked
the 5 data sheets: G15, G35, X25, G25, X35).

thanks
/alessandro

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-10-01 21:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 21:48 Alessandro Rubini
2015-10-01 21:59 ` Alessandro Rubini [this message]
2015-10-02  7:08   ` Sascha Hauer
2015-10-01 22:16 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001215936.GA1121@mail.gnudd.com \
    --to=rubini-list@gnudd.com \
    --cc=barebox@lists.infradead.org \
    --cc=braghiroli@amelchem.com \
    --cc=scaglia@amelchem.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox