From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alessandro Rubini <rubini-list@gnudd.com>
Cc: barebox@lists.infradead.org, braghiroli@amelchem.com,
scaglia@amelchem.com
Subject: Re: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)
Date: Fri, 2 Oct 2015 09:08:09 +0200 [thread overview]
Message-ID: <20151002070809.GN7858@pengutronix.de> (raw)
In-Reply-To: <20151001215936.GA1121@mail.gnudd.com>
On Thu, Oct 01, 2015 at 11:59:36PM +0200, Alessandro Rubini wrote:
> > Subject: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)
>
> Argh! After a lot of editing, the subject line is wrong.
>
> fix ROM base address (bugfix for nand ECC)
I applied the patch with this spelling fix and your name written
correctly.
>
> Anyways, let me add this detail. The current code considers the
> case where dev_request_mem_region() fails.
>
> host->pmecc_rom_base = dev_request_mem_region(dev, 3);
> if (!host->pmecc_rom_base) {
> [...]
>
> What it does in "[...]" is creating the tables with proper math.. I
> tried to skip the request_mem_region() above and ECC works perfectly,
> with the software-generated table.
>
> So I wonder whether it makes sense to just remove the declaration of
> the ROM are memory-region-3 for NAND, and just use the software-built
> tables.
Are the software defined tables on all SoCs identical to the ROM tables?
If not that may be a reason to use the software tables only as a
fallback.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-10-02 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 21:48 Alessandro Rubini
2015-10-01 21:59 ` Alessandro Rubini
2015-10-02 7:08 ` Sascha Hauer [this message]
2015-10-01 22:16 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002070809.GN7858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=braghiroli@amelchem.com \
--cc=rubini-list@gnudd.com \
--cc=scaglia@amelchem.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox