From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/5] usb: ehci-hcd: use mdelay_non_inerruptible()
Date: Wed, 7 Oct 2015 15:47:03 +0200 [thread overview]
Message-ID: <20151007134703.GA8288@ns203013.ovh.net> (raw)
In-Reply-To: <1442937514-19675-5-git-send-email-pmamonov@gmail.com>
On 18:58 Tue 22 Sep , Peter Mamonov wrote:
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
> drivers/usb/host/ehci-hcd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index d6df7b8..03d6150 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -684,7 +684,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
> * root
> */
> ehci_powerup_fixup(ehci);
> - mdelay(50);
> + mdelay_non_interruptible(50);
> ehci->portreset |= 1 << port;
> /* terminate the reset */
> ehci_writel(status_reg, reg & ~EHCI_PS_PR);
> @@ -747,7 +747,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
> goto unknown;
> }
>
> - mdelay(1);
> + mdelay_non_interruptible(1);
> len = min3(srclen, (int)le16_to_cpu(req->length), length);
> if (srcptr != NULL && len > 0)
> memcpy(buffer, srcptr, len);
> @@ -889,7 +889,7 @@ static int ehci_init(struct usb_host *host)
> ehci_writel(&ehci->hcor->or_configflag, cmd);
> /* unblock posted write */
> cmd = ehci_readl(&ehci->hcor->or_usbcmd);
> - mdelay(5);
> + mdelay_non_interruptible(5);
why do you need that much non interruptible delau?
>
> ehci->rootdev = 0;
>
> --
> 2.1.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-10-07 13:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 15:58 [PATCH v6 0/5] input: add usb keyboard driver Peter Mamonov
2015-09-22 15:58 ` [PATCH 1/5] common: clock: introduce mdelay_non_interruptible() Peter Mamonov
2015-09-22 21:15 ` Antony Pavlov
2015-09-22 21:20 ` Peter Mamonov
2015-09-22 15:58 ` [PATCH 2/5] usb: ehci-hcd: port periodic transactions implementation from the u-boot Peter Mamonov
2015-09-22 15:58 ` [PATCH 3/5] usb: ehci-hcd: detect re-entrance Peter Mamonov
2015-09-23 14:23 ` Sascha Hauer
2015-09-22 15:58 ` [PATCH 4/5] usb: ehci-hcd: use mdelay_non_inerruptible() Peter Mamonov
2015-10-07 13:47 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2015-10-07 14:40 ` Peter Mamonov
2015-10-07 15:40 ` Jean-Christophe PLAGNIOL-VILLARD
2015-10-07 16:52 ` Peter Mamonov
2015-10-12 7:00 ` Sascha Hauer
2015-10-12 11:43 ` Peter Mamonov
2015-10-12 13:44 ` Sascha Hauer
2015-10-13 10:37 ` Peter Mamonov
2015-10-13 10:38 ` Sascha Hauer
2015-10-13 2:04 ` Jean-Christophe PLAGNIOL-VILLARD
2015-10-13 9:11 ` Antony Pavlov
2015-09-22 15:58 ` [PATCH 5/5] input: port usb keyboard driver from the u-boot Peter Mamonov
2015-09-23 14:34 ` [PATCH 1/2] fixup! usb: ehci-hcd: port periodic transactions implementation " Sascha Hauer
2015-09-23 14:34 ` [PATCH 2/2] fixup! input: port usb keyboard driver " Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2015-09-21 11:30 [RFC v5 0/2] WIP: add usb keyboard driver Peter Mamonov
2015-09-21 11:30 ` [PATCH 4/5] usb: ehci-hcd: use mdelay_non_inerruptible() Peter Mamonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007134703.GA8288@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox