From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 8.mo68.mail-out.ovh.net ([46.105.74.219]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zjp4C-0006Z0-Lq for barebox@lists.infradead.org; Wed, 07 Oct 2015 13:47:38 +0000 Received: from mail181.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo68.mail-out.ovh.net (Postfix) with SMTP id 92EE9FFA047 for ; Wed, 7 Oct 2015 15:47:12 +0200 (CEST) Date: Wed, 7 Oct 2015 15:47:03 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20151007134703.GA8288@ns203013.ovh.net> References: <1442937514-19675-1-git-send-email-pmamonov@gmail.com> <1442937514-19675-5-git-send-email-pmamonov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1442937514-19675-5-git-send-email-pmamonov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 4/5] usb: ehci-hcd: use mdelay_non_inerruptible() To: Peter Mamonov Cc: barebox@lists.infradead.org On 18:58 Tue 22 Sep , Peter Mamonov wrote: > Signed-off-by: Peter Mamonov > --- > drivers/usb/host/ehci-hcd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index d6df7b8..03d6150 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -684,7 +684,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, > * root > */ > ehci_powerup_fixup(ehci); > - mdelay(50); > + mdelay_non_interruptible(50); > ehci->portreset |= 1 << port; > /* terminate the reset */ > ehci_writel(status_reg, reg & ~EHCI_PS_PR); > @@ -747,7 +747,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, > goto unknown; > } > > - mdelay(1); > + mdelay_non_interruptible(1); > len = min3(srclen, (int)le16_to_cpu(req->length), length); > if (srcptr != NULL && len > 0) > memcpy(buffer, srcptr, len); > @@ -889,7 +889,7 @@ static int ehci_init(struct usb_host *host) > ehci_writel(&ehci->hcor->or_configflag, cmd); > /* unblock posted write */ > cmd = ehci_readl(&ehci->hcor->or_usbcmd); > - mdelay(5); > + mdelay_non_interruptible(5); why do you need that much non interruptible delau? > > ehci->rootdev = 0; > > -- > 2.1.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox