mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org, vicencb@gmail.com
Subject: Re: [PATCH] fixup! detect_fs: use device instead of file
Date: Fri, 9 Oct 2015 08:31:49 +0200	[thread overview]
Message-ID: <20151009063149.GD7858@pengutronix.de> (raw)
In-Reply-To: <1444233177-21491-1-git-send-email-pmamonov@gmail.com>

On Wed, Oct 07, 2015 at 06:52:57PM +0300, Peter Mamonov wrote:
> ---
>  fs/fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fs.c b/fs/fs.c
> index c041e41..6283cea 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -1201,7 +1201,7 @@ EXPORT_SYMBOL(register_fs_driver);
>  
>  static const char *detect_fs(const char *filename)
>  {
> -	enum filetype type = cdev_detect_type(filename);
> +	enum filetype type = cdev_detect_type(basename(filename));

basename is not so nice since we do not know whether the the part of the
path we drop is really what we expect. Can we rather have a:

	if (!strncmp(filename, "/dev/", 5))
		filename += 5;

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-10-09  6:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 15:52 Peter Mamonov
2015-10-09  6:31 ` Sascha Hauer [this message]
2015-10-09 11:11   ` Peter Mamonov
2015-10-09 16:21     ` Sascha Hauer
2015-10-09 17:16       ` Vicente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151009063149.GD7858@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=pmamonov@gmail.com \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox