From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] common: filetype: is_fat_or_mbr() considered harmful
Date: Fri, 9 Oct 2015 10:06:24 +0200 [thread overview]
Message-ID: <20151009080624.GF7858@pengutronix.de> (raw)
In-Reply-To: <1444241036-23622-1-git-send-email-pmamonov@gmail.com>
Hi Peter,
On Wed, Oct 07, 2015 at 09:03:56PM +0300, Peter Mamonov wrote:
> Deleted pieces of code detect MBR-containig device as a FAT-type device,
> if it's first partition contains a FAT filesystem. So, one can mount the first
> partition of a hard drive containing FAT FS using the following command:
> barebox: mount /dev/ata0.0 /mnt/0
> as well as this one:
> barebox: mount /dev/ata0 /mnt/1
> Both commands mount the same FS.
>
> This behaviour causes automount (mount -a) to mount FAT FS
> on a first partition twice:
> barebox: mount
> none on / type ramfs
> none on /dev type devfs
> /dev/ata0 on /mnt/ata0 type fat
> /dev/ata0.0 on /mnt/ata0.0 type fat
> /dev/ata0.1 on /mnt/ata0.1 type ext4
This is_fat_or_mbr mechanism never worked very well and had funny side
effects. Would be nice to get rid of it.
Simply removing this option is not a solution though, we have to find a
proper way to keep the current feature and make it more sane.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-10-09 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 18:03 Peter Mamonov
2015-10-09 8:06 ` Sascha Hauer [this message]
2015-10-09 12:40 ` Peter Mamonov
2015-10-09 16:11 ` Sascha Hauer
2015-10-12 10:27 ` Peter Mamonov
2015-10-12 13:51 ` Sascha Hauer
2015-10-12 14:21 ` Antony Pavlov
2015-10-12 14:37 ` Franck Jullien
2015-10-13 8:32 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009080624.GF7858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox