From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1] fixup! detect_fs: use device instead of file
Date: Tue, 13 Oct 2015 09:44:11 +0200 [thread overview]
Message-ID: <20151013074411.GB7858@pengutronix.de> (raw)
In-Reply-To: <1444655717-10885-1-git-send-email-pmamonov@gmail.com>
Hi Peter,
I was about to apply this one, but there are two problems with it.
First I cannot apply this as a fixup patch since the patch breaking it
is already in master which I do not rebase. So we need a patch with a
proper commit message. I would add that myself, but I noticed that your
patch misses a proper signed-off-by. Could you add that and resend?
Sascha
On Mon, Oct 12, 2015 at 04:15:17PM +0300, Peter Mamonov wrote:
> ---
> fs/fs.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fs.c b/fs/fs.c
> index c041e41..c2a20e1 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -1201,10 +1201,14 @@ EXPORT_SYMBOL(register_fs_driver);
>
> static const char *detect_fs(const char *filename)
> {
> - enum filetype type = cdev_detect_type(filename);
> + enum filetype type;
> struct driver_d *drv;
> struct fs_driver_d *fdrv;
>
> + if (!strncmp(filename, "/dev/", 5))
> + filename += 5;
> + type = cdev_detect_type(filename);
> +
> if (type == filetype_unknown)
> return NULL;
>
> --
> 2.1.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-10-13 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 13:15 Peter Mamonov
2015-10-13 7:44 ` Sascha Hauer [this message]
2015-10-13 11:26 ` [PATCH v1 resend] " Peter Mamonov
2015-10-13 14:09 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013074411.GB7858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox