Re: [PATCH 00/17] Armada 370/XP NAND driver

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Oct 13, 2015 at 11:53:14AM +0200, Sebastian Hesselbarth wrote:
> On 13.10.2015 11:35, Robert Jarzmik wrote:
> >Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> writes:
> >
> >>On 12.10.2015 21:16, Robert Jarzmik wrote:
> >>>Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> writes:
> >>>
> >>>>I have prepared a branch for you based on above v2015.10.0 to ease
> >>>>testing with all comments included so far:
> >>>>
> >>>>https://github.com/shesselba/barebox-dove.git testing/nfc-for-robert
> >>>That's cool, really.
> >>>
> >>>It doesn't work yet :
> >>>	clk = clk_get_sys("nand", NULL);
> >>>	printf("%s(): clk = %p\n", __func__, clk);
> >>>=>
> >>>          zylonite_devices_init(): clk = fffffffe
> >>
> >>Ok, thanks for testing.
> >>
> >>I've fast-forward pushed the branch with one last try for today again.
> >>Misread clk_get, clk_find and clk_register_clkdev and friends.
> >Well, I still have a probe error :
> >	alloc_nand_resource(): clk_get() -> fffffffe
> >	mrvl_nand mrvl_nand0: alloc nand resource failed
> >	mrvl_nand mrvl_nand0: probe failed: No such file or directory
> >	zylonite_devices_init(): clk = 83703328
> 
> Hmm. I have to have a closer look at how clkdev lookup is supposed
> to work then. Thanks for testing up to here, it will take a day or
> two until I can get back to it.

In your temporary patch you have:

> @@ -67,6 +71,9 @@ static int zylonite_devices_init(void)
>  			   &smsc91x_pdata);
>  	add_generic_device("mrvl_nand", DEVICE_ID_DYNAMIC, NULL,
>  			   0x43100000, 0x1000, IORESOURCE_MEM, &nand_pdata);
> +	clk = clk_get_sys("nand", NULL);
> +	if (!IS_ERR(clk))
> +		clkdev_add_physbase(clk, 0x43100000, NULL);

Could it be that you register the clk lookup after the nand driver is probed? This
hunk should be moved before the nand device registration.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox