From: Sascha Hauer <s.hauer@pengutronix.de>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/3] scripts/kwbimage: Make BINARY files relative to config file
Date: Thu, 15 Oct 2015 12:44:48 +0200 [thread overview]
Message-ID: <20151015104448.GX7858@pengutronix.de> (raw)
In-Reply-To: <20151015110037.7bfef9ab@free-electrons.com>
On Thu, Oct 15, 2015 at 11:00:37AM +0200, Thomas Petazzoni wrote:
> Sascha,
>
> On Thu, 15 Oct 2015 10:18:55 +0200, Sascha Hauer wrote:
> > The BINARY files given in the config files are expected to be relative
> > to the place kwbimage is called from. This is bad since it breaks where
> > kwbimage is called from the build directory and not the source
> > directory.
> > It makes more sense to make the paths in the config files relative
> > to the config files which works with out of tree builds and is also
> > more what a user normally expects.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> In practice those binary.0 files are not really part of the Barebox
> source code. The binary.0 file has to be extracted from a vendor U-Boot
> binary prior to doing the Barebox build, so it isn't exactly part of
> the "source tree".
Yes, right.
>
> Though I agree it is probably easier to extract them once and keep them
> around in the source tree (not checked-in, of course).
I think this aswell. The build tree often is deleted, but then the
binary.0 images should still be available.
>
> Note that U-Boot now has a fully open-source implementation of this
> binary.0 thing, at least for Armada XP and Armada 38x. However, it's
> basically copy/pasted from the vendor U-Boot, so it's not very pretty
> to look at:
>
> - http://git.denx.de/?p=u-boot.git;a=tree;f=drivers/ddr/marvell
> for the DDR initialization code.
Nice to have, indeed not nice to look at. This code is huge...
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-10-15 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 8:18 Sascha Hauer
2015-10-15 8:18 ` [PATCH 1/3] scripts/kwbimage: Move configfile opening to the function that reads it Sascha Hauer
2015-10-15 8:18 ` [PATCH 2/3] scripts/kwbimage: Make BINARY files relative to config file Sascha Hauer
2015-10-15 9:00 ` Thomas Petazzoni
2015-10-15 9:29 ` Sebastian Hesselbarth
2015-10-15 9:44 ` Thomas Petazzoni
2015-10-19 6:40 ` Sascha Hauer
2015-10-15 10:44 ` Sascha Hauer [this message]
2015-10-15 8:18 ` [PATCH 3/3] ARM: mvebu: Lenovo IX4 300D: Fix pblb generation Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015104448.GX7858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox